Skip to content
This repository has been archived by the owner on Oct 2, 2020. It is now read-only.

Add SHTC1, SHTC3 #2287

Merged
merged 1 commit into from
Jan 8, 2020
Merged

Add SHTC1, SHTC3 #2287

merged 1 commit into from
Jan 8, 2020

Conversation

DanSGiesbrecht
Copy link
Collaborator

@DanSGiesbrecht DanSGiesbrecht commented Nov 5, 2019 •
edited
Loading

Add SHTC1/SHTC3 Humidity and Temperature Sensors

Travis error: will be resolved by Footprint PR merge.

symbol

  • Provide a URL to a datasheet for the symbol(s) you are contributing
  • An example screenshot image is very helpful
  • Ensure that the associated footprints match the official footprint library
    • A new fitting footprint must be submitted if the library does not yet contain one.
  • If there are matching footprint PRs, provide link(s) as appropriate
  • Check the output of the Travis automated check scripts - fix any errors as required
  • Give a reason behind any intentional library convention rule violation.

@DanSGiesbrecht DanSGiesbrecht added Addition Adds new symbols to library Pending footprint Pending footprint acceptance before merging Pending reviewer A pull request waiting for a reviewer labels Nov 5, 2019
@cpresser cpresser self-assigned this Nov 9, 2019
@cpresser
Copy link
Contributor

cpresser commented Nov 9, 2019

  • Pin names, types, position are all good.
  • Description + alias also checks out.

As soon as the FP is done I am ready to merge this.

@DanSGiesbrecht DanSGiesbrecht removed the Pending reviewer A pull request waiting for a reviewer label Nov 9, 2019
@DanSGiesbrecht DanSGiesbrecht reopened this Jan 7, 2020
@DanSGiesbrecht
Copy link
Collaborator Author

Close/reopen to force Travis check.

@DanSGiesbrecht
Copy link
Collaborator Author

@cpresser this is good-to-go! :)

@DanSGiesbrecht DanSGiesbrecht removed the Pending footprint Pending footprint acceptance before merging label Jan 7, 2020
@cpresser cpresser merged commit 28ac68d into KiCad:master Jan 8, 2020
@cpresser
Copy link
Contributor

cpresser commented Jan 8, 2020

Thanks, merged!

Close/reopen to force Travis check.

Slightly related comment:
Travis has a 'Restart Build' button. See https://stackoverflow.com/questions/17606874/trigger-a-travis-ci-rebuild-without-pushing-a-commit
Login with the github-account does work for that usecase.

@antoniovazquezblanco antoniovazquezblanco added this to the 5.1.6 milestone Jan 9, 2020
@DanSGiesbrecht DanSGiesbrecht deleted the dev/sht branch January 9, 2020 16:12
jamesrlucas pushed a commit to jamesrlucas/kicad-symbols that referenced this pull request Apr 20, 2020
@DanSGiesbrecht @jamesrlucas
Add SHTC1, SHTC3 (KiCad#2287)
be756b5
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@cpresser cpresser

Labels
Addition Adds new symbols to library
Projects
None yet
Milestone
5.1.6
Development

Successfully merging this pull request may close these issues.
3 participants
@DanSGiesbrecht @cpresser @antoniovazquezblanco