Skip to content

irinterp: refine :nothrow only when it is not proved yet #50764

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 3, 2023
Merged

irinterp: refine :nothrow only when it is not proved yet #50764

merged 1 commit into from
Aug 3, 2023

Conversation

aviatesk
Copy link
Member

@aviatesk aviatesk commented Aug 2, 2023

This makes irinterp not override :nothrow=true that are assumed by Base.@assume_effects.

@aviatesk aviatesk requested a review from Keno August 2, 2023 18:33
@aviatesk aviatesk force-pushed the avi/semi-concrete-nothrow branch from 4f7c05c to 7878843 Compare August 2, 2023 18:55
@oscardssmith oscardssmith added compiler:effects effect analysis performance Must go faster labels Aug 2, 2023
This was referenced Aug 2, 2023
Merged
Merged
@oscardssmith oscardssmith added the backport 1.10 Change should be backported to the 1.10 release label Aug 2, 2023
@aviatesk
irinterp: refine :nothrow only when it is not proved yet
e3ae49a 
This makes irinterp not override `:nothrow=true` that are assumed by
`Base.@assume_effects`.
@aviatesk aviatesk force-pushed the avi/semi-concrete-nothrow branch from 470791d to e3ae49a Compare August 3, 2023 04:31
@aviatesk aviatesk merged commit 2a8eca3 into master Aug 3, 2023
@aviatesk aviatesk deleted the avi/semi-concrete-nothrow branch August 3, 2023 10:56
aviatesk added a commit that referenced this pull request Aug 3, 2023
@aviatesk
optimizer: move inlineable constants into argument position during `c…
a2f3d77 
…ompact!`-ion (#50767)

In code like below
```julia
Base.@assume_effects :nothrow function erase_before_inlining(x, y)
    z = sin(y)
    if x
        return "julia"
    end
    return z
end

let y::Float64
    length(erase_before_inlining(true, y))
end
```
the constant prop' can figure out the constant return type of
`erase_before_inlining(true, y)` while it is profitable not to inline
expand it since otherwise we left some `!:nothrow` callees there
(xref: #47305).

In order to workaround this problem, this commit makes `compact!`move
inlineable constants into argument positions so that the such
"inlineable, but safe as a whole" calls to be erased during compaction.
This should give us general compile-time performance improvement too
as we no longer need to expand the IR for those calls.

Requires:
- #50764
- #50765
- #50768
aviatesk added a commit that referenced this pull request Aug 4, 2023
@aviatesk
irinterp: refine :nothrow only when it is not proved yet (#50764)
f10c461 
This makes irinterp not override `:nothrow=true` that are assumed by
`Base.@assume_effects`.
aviatesk added a commit that referenced this pull request Aug 4, 2023
@aviatesk
optimizer: move inlineable constants into argument position during `c…
9e9f67d 
…ompact!`-ion (#50767)

In code like below
```julia
Base.@assume_effects :nothrow function erase_before_inlining(x, y)
    z = sin(y)
    if x
        return "julia"
    end
    return z
end

let y::Float64
    length(erase_before_inlining(true, y))
end
```
the constant prop' can figure out the constant return type of
`erase_before_inlining(true, y)` while it is profitable not to inline
expand it since otherwise we left some `!:nothrow` callees there
(xref: #47305).

In order to workaround this problem, this commit makes `compact!`move
inlineable constants into argument positions so that the such
"inlineable, but safe as a whole" calls to be erased during compaction.
This should give us general compile-time performance improvement too
as we no longer need to expand the IR for those calls.

Requires:
- #50764
- #50765
- #50768
@aviatesk aviatesk removed the backport 1.10 Change should be backported to the 1.10 release label Aug 4, 2023
@aviatesk aviatesk mentioned this pull request Aug 4, 2023
Merged
36 tasks
KristofferC added a commit that referenced this pull request Aug 16, 2023
@KristofferC
Backports for julia v1.10.0-beta2 (#50708)
77e7e73 
Backported PRs:
- [x] #50637 <!-- Remove SparseArrays legacy code -->
- [x] #50665 <!-- print `@time` msg into print buffer -->
- [x] #50523 <!-- Avoid generic call in most cases for getproperty -->
- [x] #50635 <!-- `versioninfo()`: include build info and unofficial
warning -->
- [x] #50670 <!-- Make reinterpret specialize fully. -->
- [x] #50666 <!-- include `--pkgimage=no` caches for stdlibs -->
- [x] #50765 
- [x] #50764
- [x] #50768
- [x] #50767
- [x] #50618 <!-- inference: continue const-prop' when concrete-eval
returns non-inlineable -->
- [x] #50689 <!-- Attach `tanpi` docstring to method -->
- [x] #50671 <!-- Fix rdiv of complex lhs by real factorizations -->
- [x] #50598 <!-- only limit types in stack traces in the REPL -->
- [x] #50766 <!-- Don't partition alwaysinline functions -->
- [x] #50771 <!-- re-allow non-string values in ENV `get!` -->
- [x] #50682 <!-- Add fallback if we have make a weird GC decision. -->
- [x] #50781 <!-- fix `bit_map!` with aliasing -->
- [x] #50172 <!-- print feature flags used for matching pkgimage -->
- [x] #50844 <!-- Bump OpenBLAS binaries to use the new GEMM
multithreading threshold -->
- [x] #50826 <!-- Update dependency builds -->
- [x] #50845 <!-- fix #50438, use default pool for at-threads -->
- [x] #50568 <!-- `Array(::AbstractRange)` should return an `Array` -->
- [x] #50655 <!-- fix hashing regression. -->
- [x] #50779 <!-- Minor refactor to image generation -->
- [x] #50791 <!-- Make symbols internal in jl_create_native, and only
externalize them when partitioning -->
- [x] #50724 <!-- Merge opaque closure modules with the rest of the
workqueue -->
- [x] #50738 <!-- Add alignment to constant globals -->
- [x] #50871 <!-- macOS: Don't inspect dead threadtls during exception
handling. -->

Need manual backport:

Contains multiple commits, manual intervention needed:

Non-merged PRs with backport label:
- [ ] #50850 <!-- Remove weird Rational dispatch and add pi functions to
list -->
- [ ] #50823 <!-- Make ranges more robust with unsigned indexes. -->
- [ ] #50809 <!-- Limit type-printing in MethodError -->
- [ ] #50663 <!-- Fix Expr(:loopinfo) codegen -->
- [ ] #50594 <!-- Disallow non-index Integer types in isassigned -->
- [ ] #50385 <!-- Precompile pidlocks: add to NEWS and docs -->
- [ ] #49805 <!-- Limit TimeType subtraction to AbstractDateTime -->
@mofeing mofeing mentioned this pull request Oct 27, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Keno Keno Keno approved these changes

@oscardssmith oscardssmith oscardssmith approved these changes

Assignees
No one assigned
Labels
compiler:effects effect analysis performance Must go faster
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aviatesk @Keno @oscardssmith