inference: continue const-prop' when concrete-eval returns non-inlineable

[aviatesk]

This commit fixes the regression in the following example:

julia> stritr() = iterate(("1", '2'), 1);

julia> @time stritr();
  0.000001 seconds (2 allocations: 64 bytes) # on master
  0.000000 seconds                           # on 1.9

The problem is that currently we don't inline result of concrete-eval when its result is not inlineable, although const-prop' or semi-concrete eval may be able to optimize and inline the method body. To improve the situation, this commit simply allows abstract_call_method_with_const_args to continue to semi-concrete eval and const-prop' when concrete-eval returned non-inlineable result.

@nanosoldier runbenchmarks(!"scalar", vs=":master")

[nanosoldier]

Your benchmark job has completed - possible performance regressions were detected. A full report can be found here.

[aviatesk]

@nanosoldier runbenchmarks(!"scalar", vs=":master")

[nanosoldier]

Your benchmark job has completed - possible performance regressions were detected. A full report can be found here.

[oscardssmith]

why can't we just widenconst the result?

[aviatesk]

Concrete evaluation only returns a result value, not optimized body of the method. When we can't inline the concrete-eval result, it is more efficient if we can inline optimized method body.

[vtjnash]

(note that the commit message may need some corrections when merging, since it is attempting to ping several users, which is bad for a commit message)

[aviatesk]

@nanosoldier runtests(ALL, vs = ":master")

[nanosoldier]

The package evaluation job you requested has completed - possible new issues were detected.
The full report is available.

[aviatesk]

This turns out to be still WIP 'cause I found the following kind of cases are not well optimized by this PR:

julia> Base.@assume_effects :foldable function continue_const_prop(i, j)
           chars = map(Char, i:j)
           String(chars)
       end
continue_const_prop (generic function with 1 method)

julia> code_typed() do
           length(continue_const_prop(1, 5))
       end
1-element Vector{Any}:
 CodeInfo(
1 ─ %1 = invoke Base._collect($(QuoteNode(1:5))::UnitRange{Int64}, $(QuoteNode(Base.Generator{UnitRange{Int64}, Type{Char}}(Char, 1:5)))::Base.Generator{UnitRange{Int64}, Type{Char}}, $(QuoteNode(Base.EltypeUnknown()))::Base.EltypeUnknown, $(QuoteNode(Base.HasShape{1}()))::Base.HasShape{1})::Vector{Char}
│        invoke Main.String(%1::Vector{Char})::String
└──      return 5
) => Int64

This is because now continue_const_prop is inlined and then the inlined body isn't DCE-eligible. Previously this example is fully optimized as all concrete-evaluated calls are folded into constant or noinlined.

[aviatesk]

This PR requires #50764, #50765 and #50767 to be completed.

[aviatesk]

@nanosoldier runbenchmarks(!"scalar", vs=":master")

[vtjnash]

SGTM

[nanosoldier]

Your benchmark job has completed - possible performance regressions were detected. A full report can be found here.

[aviatesk]

@nanosoldier runbenchmarks(!"scalar", vs=":master")

[nanosoldier]

Your benchmark job has completed - possible performance regressions were detected. A full report can be found here.