Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

include --pkgimage=no caches for stdlibs #50666

Merged
merged 1 commit into from
Jul 27, 2023
Merged

include --pkgimage=no caches for stdlibs #50666

merged 1 commit into from
Jul 27, 2023

Conversation

IanButterworth
Copy link
Member

@IanButterworth IanButterworth commented Jul 25, 2023 •
edited
Loading

@IanButterworth IanButterworth mentioned this pull request Jul 25, 2023
Closed
@DilumAluthge
Copy link
Member

These will just be .ji files, right? Are those going to be relocatable from the Buildkite build machines to the user's machines?

@IanButterworth
Copy link
Member Author

I believe so

@DilumAluthge
Copy link
Member

Hmmm. I was under the impression that, currently, .ji files are not relocatable, at least not until #45215 (also #47943) is fixed.

@vchuravy
Copy link
Member

The stdlib files are relocatable (we cheat during loading)

@IanButterworth
Copy link
Member Author

IanButterworth commented Jul 25, 2023 •
edited
Loading

I tried this build out over at https://github.com/JuliaIO/PNGFiles.jl/actions/runs/5651757432/job/15310363183?pr=66

and while I don't see any precompilation of the stdlibs now, other packages are now being precompiled and it's not clear to me why

Actually there are stdlibs being re-precompiled and more packages

The action turned out to not be caching properly because I didn't set cache-name appropriately, and it has a generic default which is a bit of a footgun. That might need rethinking.

So this seems good. Just needs a buildkite fix JuliaCI/julia-buildkite#312

@IanButterworth IanButterworth mentioned this pull request Jul 25, 2023
Merged
@IanButterworth IanButterworth merged commit 62605cc into JuliaLang:master Jul 27, 2023
1 check passed
@IanButterworth IanButterworth deleted the ib/stdlib_no_pkgimg_cache branch July 27, 2023 17:35
@DilumAluthge
Copy link
Member

Is there any need to backport this?

@IanButterworth IanButterworth added backport 1.9 Change should be backported to release-1.9 backport 1.10 Change should be backported to the 1.10 release labels Jul 27, 2023
KristofferC pushed a commit that referenced this pull request Jul 28, 2023
@IanButterworth @KristofferC
include --pkgimage=no caches for stdlibs (#50666)
21fe723 
(cherry picked from commit 62605cc)
@KristofferC KristofferC mentioned this pull request Jul 28, 2023
Merged
36 tasks
@KristofferC KristofferC mentioned this pull request Aug 10, 2023
Merged
35 tasks
KristofferC added a commit that referenced this pull request Aug 16, 2023
@KristofferC
Backports for julia v1.10.0-beta2 (#50708)
77e7e73 
Backported PRs:
- [x] #50637 <!-- Remove SparseArrays legacy code -->
- [x] #50665 <!-- print `@time` msg into print buffer -->
- [x] #50523 <!-- Avoid generic call in most cases for getproperty -->
- [x] #50635 <!-- `versioninfo()`: include build info and unofficial
warning -->
- [x] #50670 <!-- Make reinterpret specialize fully. -->
- [x] #50666 <!-- include `--pkgimage=no` caches for stdlibs -->
- [x] #50765 
- [x] #50764
- [x] #50768
- [x] #50767
- [x] #50618 <!-- inference: continue const-prop' when concrete-eval
returns non-inlineable -->
- [x] #50689 <!-- Attach `tanpi` docstring to method -->
- [x] #50671 <!-- Fix rdiv of complex lhs by real factorizations -->
- [x] #50598 <!-- only limit types in stack traces in the REPL -->
- [x] #50766 <!-- Don't partition alwaysinline functions -->
- [x] #50771 <!-- re-allow non-string values in ENV `get!` -->
- [x] #50682 <!-- Add fallback if we have make a weird GC decision. -->
- [x] #50781 <!-- fix `bit_map!` with aliasing -->
- [x] #50172 <!-- print feature flags used for matching pkgimage -->
- [x] #50844 <!-- Bump OpenBLAS binaries to use the new GEMM
multithreading threshold -->
- [x] #50826 <!-- Update dependency builds -->
- [x] #50845 <!-- fix #50438, use default pool for at-threads -->
- [x] #50568 <!-- `Array(::AbstractRange)` should return an `Array` -->
- [x] #50655 <!-- fix hashing regression. -->
- [x] #50779 <!-- Minor refactor to image generation -->
- [x] #50791 <!-- Make symbols internal in jl_create_native, and only
externalize them when partitioning -->
- [x] #50724 <!-- Merge opaque closure modules with the rest of the
workqueue -->
- [x] #50738 <!-- Add alignment to constant globals -->
- [x] #50871 <!-- macOS: Don't inspect dead threadtls during exception
handling. -->

Need manual backport:

Contains multiple commits, manual intervention needed:

Non-merged PRs with backport label:
- [ ] #50850 <!-- Remove weird Rational dispatch and add pi functions to
list -->
- [ ] #50823 <!-- Make ranges more robust with unsigned indexes. -->
- [ ] #50809 <!-- Limit type-printing in MethodError -->
- [ ] #50663 <!-- Fix Expr(:loopinfo) codegen -->
- [ ] #50594 <!-- Disallow non-index Integer types in isassigned -->
- [ ] #50385 <!-- Precompile pidlocks: add to NEWS and docs -->
- [ ] #49805 <!-- Limit TimeType subtraction to AbstractDateTime -->
@KristofferC KristofferC removed the backport 1.10 Change should be backported to the 1.10 release label Aug 18, 2023
@IanButterworth IanButterworth mentioned this pull request Aug 19, 2023
Merged
31 tasks
@IanButterworth IanButterworth removed the backport 1.9 Change should be backported to release-1.9 label Aug 19, 2023
@IanButterworth
Copy link
Member Author

Mistakenly marked for backport-1.9. 1.9 doesn't have pkgimage stdlibs

@mofeing mofeing mentioned this pull request Oct 27, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vchuravy vchuravy vchuravy approved these changes

@staticfloat staticfloat Awaiting requested review from staticfloat

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@IanButterworth @DilumAluthge @vchuravy @KristofferC