Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert #44101, revert #44097, and revert #43852 #44123

Closed
wants to merge 3 commits into from

Conversation

DilumAluthge
Copy link
Member

@DilumAluthge DilumAluthge commented Feb 11, 2022

I now believe that the recent CI breakage had nothing to do with the public https://badssl.com/ instance. Instead, I believe that the breakage was caused by one (or more) of the following pull requests:

  1. Take purity modeling seriously #43852 (f090992)
  2. inlining: use ConstResult if available #44101 (fed4544)
  3. Fix doctests for CodeUnits indexing. #44105 (0bf6ce3)

This PR reverts the above three PRs.

@DilumAluthge DilumAluthge added DO NOT MERGE Do not merge this PR! ci Continuous integration labels Feb 11, 2022
@Keno
Copy link
Member

Keno commented Feb 11, 2022

#44097 is unrelated

@Keno
Copy link
Member

Keno commented Feb 11, 2022

#44105 is related though, but only affects doctests so this should be enough to test your hypothesis.

@DilumAluthge
Copy link
Member Author

#44105 is related though, but only affects doctests so this should be enough to test your hypothesis.

Yeah I just noticed that the doctests are failing, but yeah I agree, let's first see what the testers say.

@DilumAluthge
Copy link
Member Author

DilumAluthge commented Feb 11, 2022

@Keno Except for the doctests, all CI jobs are passing on d21e8eb (https://buildkite.com/julialang/julia-master/builds/8632)

I'm going to remove the revert of #44097 and add a revert of #44105.

@DilumAluthge
Copy link
Member Author

If all CI jobs pass, I'd be fine with merging this PR, with the plan of re-landing the three reverted PRs once the underlying bug is fixed.

@DilumAluthge DilumAluthge marked this pull request as draft February 11, 2022 07:56
@DilumAluthge DilumAluthge added the DO NOT MERGE Do not merge this PR! label Feb 11, 2022
@Keno Keno closed this in #44125 Feb 11, 2022
@DilumAluthge DilumAluthge deleted the dpa/revert-43852-44097-44101 branch February 11, 2022 18:03
@DilumAluthge DilumAluthge removed the DO NOT MERGE Do not merge this PR! label Feb 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Continuous integration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants