-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert #44101, revert #44097, and revert #43852 #44123
Conversation
#44097 is unrelated |
#44105 is related though, but only affects doctests so this should be enough to test your hypothesis. |
Yeah I just noticed that the doctests are failing, but yeah I agree, let's first see what the testers say. |
@Keno Except for the doctests, all CI jobs are passing on d21e8eb (https://buildkite.com/julialang/julia-master/builds/8632) I'm going to remove the revert of #44097 and add a revert of #44105. |
d21e8eb
to
d844050
Compare
If all CI jobs pass, I'd be fine with merging this PR, with the plan of re-landing the three reverted PRs once the underlying bug is fixed. |
I now believe that the recent CI breakage had nothing to do with the public https://badssl.com/ instance. Instead, I believe that the breakage was caused by one (or more) of the following pull requests:
ConstResult
if available #44101 (fed4544)This PR reverts the above three PRs.