Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

actually add the atributes #44097

Merged
merged 3 commits into from
Feb 10, 2022

Conversation

@oscardssmith oscardssmith added the bugfix This change fixes an existing bug label Feb 9, 2022
src/codegen.cpp Outdated Show resolved Hide resolved
@oscardssmith
Copy link
Member Author

the second commit should also fix the windows ci failure mentioned in #44036 (comment)

@oscardssmith
Copy link
Member Author

Can we merge this quickly? This fixes windows CI.

@DilumAluthge DilumAluthge merged commit 708873a into JuliaLang:master Feb 10, 2022
@oscardssmith oscardssmith deleted the fix-donotdelete-builtin branch February 10, 2022 15:04
DilumAluthge added a commit that referenced this pull request Feb 11, 2022
antoine-levitt pushed a commit to antoine-levitt/julia that referenced this pull request Feb 17, 2022
Co-authored-by: oscarddssmith <oscar.smith@juliacomputing.com>
LilithHafner pushed a commit to LilithHafner/julia that referenced this pull request Feb 22, 2022
Co-authored-by: oscarddssmith <oscar.smith@juliacomputing.com>
LilithHafner pushed a commit to LilithHafner/julia that referenced this pull request Mar 8, 2022
Co-authored-by: oscarddssmith <oscar.smith@juliacomputing.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix This change fixes an existing bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants