actually add the atributes #44097
Merged
actually add the atributes #44097
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KristofferC
reviewed
Feb 9, 2022
|
the second commit should also fix the windows ci failure mentioned in #44036 (comment) |
|
Can we merge this quickly? This fixes windows CI. |
DilumAluthge
added a commit
that referenced
this pull request
Feb 11, 2022
This reverts commit 708873a.
antoine-levitt
pushed a commit
to antoine-levitt/julia
that referenced
this pull request
Feb 17, 2022
Co-authored-by: oscarddssmith <oscar.smith@juliacomputing.com>
LilithHafner
pushed a commit
to LilithHafner/julia
that referenced
this pull request
Feb 22, 2022
Co-authored-by: oscarddssmith <oscar.smith@juliacomputing.com>
LilithHafner
pushed a commit
to LilithHafner/julia
that referenced
this pull request
Mar 8, 2022
Co-authored-by: oscarddssmith <oscar.smith@juliacomputing.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes https://github.com/JuliaLang/julia/pull/44036/files/3f2a3237e9de0f58c3cbc16bcbaceaa535dc4b42#r802922446