Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use our own custom badssl.julialang.org implementation #178

Merged
merged 1 commit into from
Feb 12, 2022

Conversation

DilumAluthge
Copy link
Member

Follow-up to #176 and #177.

@DilumAluthge
Copy link
Member Author

@staticfloat @StefanKarpinski We now have some evidence suggesting that the public badssl.com instance was not the cause of the Base Julia CI failures. More details in JuliaLang/julia#44123.

So, while we still want to ultimately move to using our own instance, there is now no longer any rush on that. So I would say that @staticfloat can take his time working on a custom implementation for these two endpoints (untrusted-root and wrong.host), and then we can wait until that work is done before we merge this PR.

@codecov
Copy link

codecov bot commented Feb 11, 2022

Codecov Report

Merging #178 (53bb556) into master (a41840c) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #178   +/-   ##
=======================================
  Coverage   92.47%   92.47%           
=======================================
  Files           5        5           
  Lines         518      518           
=======================================
  Hits          479      479           
  Misses         39       39           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a41840c...53bb556. Read the comment docs.

@DilumAluthge DilumAluthge force-pushed the dpa/use-our-own-custom-badssl-instance branch from 73c326d to 53bb556 Compare February 12, 2022 09:13
@DilumAluthge DilumAluthge marked this pull request as ready for review February 12, 2022 09:13
@DilumAluthge
Copy link
Member Author

DilumAluthge commented Feb 12, 2022

We now have our own custom instance of badssl:

  1. https://github.com/staticfloat/badssl.julialang.org
  2. badssl.julialang.org

Therefore, this PR is now ready to merge (assuming that all CI jobs pass).

@DilumAluthge DilumAluthge merged commit 2a21b15 into master Feb 12, 2022
@DilumAluthge DilumAluthge deleted the dpa/use-our-own-custom-badssl-instance branch February 12, 2022 09:35
@DilumAluthge
Copy link
Member Author

@StefanKarpinski StefanKarpinski mentioned this pull request Mar 24, 2022
StefanKarpinski pushed a commit that referenced this pull request Mar 24, 2022
StefanKarpinski pushed a commit that referenced this pull request Mar 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant