-
-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use our own custom badssl.julialang.org
implementation
#178
Conversation
@staticfloat @StefanKarpinski We now have some evidence suggesting that the public badssl.com instance was not the cause of the Base Julia CI failures. More details in JuliaLang/julia#44123. So, while we still want to ultimately move to using our own instance, there is now no longer any rush on that. So I would say that @staticfloat can take his time working on a custom implementation for these two endpoints ( |
Codecov Report
@@ Coverage Diff @@
## master #178 +/- ##
=======================================
Coverage 92.47% 92.47%
=======================================
Files 5 5
Lines 518 518
=======================================
Hits 479 479
Misses 39 39 Continue to review full report at Codecov.
|
73c326d
to
53bb556
Compare
We now have our own custom instance of badssl:
Therefore, this PR is now ready to merge (assuming that all CI jobs pass). |
(cherry picked from commit 2a21b15)
(cherry picked from commit 2a21b15)
Follow-up to #176 and #177.