Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] refactor codebase with functor APIs #29

Merged
merged 53 commits into from
Jul 31, 2019
Merged

[WIP] refactor codebase with functor APIs #29

merged 53 commits into from
Jul 31, 2019

Commits on Jul 21, 2019

  1. Configuration menu
    Copy the full SHA
    db54698 View commit details
    Browse the repository at this point in the history
  2. adapt BinarizationAPI and reorganize codes

    * replace `BinarizationAlgorithm` with `AbstractImageBinarizationAlgorithm`
    * import `binarize` and `binarize!` from `BinarizationAPI`
    * move concrete algorithms struct definitions to seperated files
    
    This is a intermediate commit as a start point for the following code refactor, i.e.,
    moving implementations to concrete functors
    johnnychen94 committed Jul 21, 2019
    Configuration menu
    Copy the full SHA
    7158a72 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    6297fc9 View commit details
    Browse the repository at this point in the history

Commits on Jul 22, 2019

  1. Configuration menu
    Copy the full SHA
    dd36223 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    10c8eaa View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    0fda77b View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    7a1f0fc View commit details
    Browse the repository at this point in the history
  5. swap argument order

    johnnychen94 committed Jul 22, 2019
    Configuration menu
    Copy the full SHA
    d1f8309 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    b7ed27e View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    ca471b8 View commit details
    Browse the repository at this point in the history

Commits on Jul 24, 2019

  1. refactor and enhance AdaptiveThreshold method (#30)

    * move implementations to AdaptiveThreshold functor
    
    * Rewrite AdaptiveThreshold with CartesianIndices to support n-D images
    
    * update and simplify the docstring
    
    * enhance the test codes and fix several bugs
    
    * add CartetianIndex compat to Julia 1.0
    
    * deprecate `window_size` and `recommend_size`
    johnnychen94 committed Jul 24, 2019
    Configuration menu
    Copy the full SHA
    95184f6 View commit details
    Browse the repository at this point in the history

Commits on Jul 25, 2019

  1. refactor Balanced using the functor API

    This is a PR-commit for PR
    #29
    that refactors the whole codebase to use the new functor API, which
    is discussed in more details in
    #26
    and explained in my GSoC 2019 blog
    https://nextjournal.com/johnnychen94/the-principles-of-imagesjl-part-i
    
    Changes:
    
    * move implementations into functor
    * enhance the test codes with wider test coverage
    johnnychen94 committed Jul 25, 2019
    Configuration menu
    Copy the full SHA
    4c7a345 View commit details
    Browse the repository at this point in the history
  2. refactor Entropy using the functor API

    This is a PR-commit for PR
    #29 that
    refactors the whole codebase to use the new functor API, which
    is discussed in more details in
    #26 and
    explained in my [GSoC 2019
    blog](https://nextjournal.com/johnnychen94/the-principles-of-imagesjl-part-i)
    
    Changes:
    
    * support `Color3` input
    * move implementations into functor
    * enhance the test codes with wider test coverage
    johnnychen94 committed Jul 25, 2019
    Configuration menu
    Copy the full SHA
    24fd5f3 View commit details
    Browse the repository at this point in the history
  3. refactor Intermodes using the functor API

    This is a PR-commit for PR
    #29 that
    refactors the whole codebase to use the new functor API, which
    is discussed in more details in
    #26 and
    explained in my [GSoC 2019
    blog](https://nextjournal.com/johnnychen94/the-principles-of-imagesjl-part-i)
    
    Changes:
    
    * support `Color3` input
    * move implementations into functor
    * enhance the test codes with wider test coverage
    johnnychen94 committed Jul 25, 2019
    Configuration menu
    Copy the full SHA
    67d3cfb View commit details
    Browse the repository at this point in the history
  4. update example code

    johnnychen94 authored Jul 25, 2019
    Configuration menu
    Copy the full SHA
    0834e87 View commit details
    Browse the repository at this point in the history
  5. update example code

    johnnychen94 authored Jul 25, 2019
    Configuration menu
    Copy the full SHA
    28ebf62 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    7b8b5d0 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    78903b2 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    2a55876 View commit details
    Browse the repository at this point in the history
  9. refactor MinimumError using functor API

    This is a PR-commit for PR
    #29 that
    refactors the whole codebase to use the new functor API, which is
    discussed in more details in
    #26 and
    explained in my [GSoC 2019
    blog](https://nextjournal.com/johnnychen94/the-principles-of-imagesjl-part-i)
    
    Changes:
    
    * support `Color3` input
    * move implementations into functor
    * enhance the test codes with wider test coverage
    johnnychen94 committed Jul 25, 2019
    Configuration menu
    Copy the full SHA
    fcaacc4 View commit details
    Browse the repository at this point in the history
  10. refactor MinimumIntermodes using functor API

    This is a PR-commit for PR
    #29 that
    refactors the whole codebase to use the new functor API, which is
    discussed in more details in
    #26 and
    explained in my [GSoC 2019
    blog](https://nextjournal.com/johnnychen94/the-principles-of-imagesjl-part-i)
    
    Changes:
    
    * support `Color3` input
    * move implementations into functor
    * enhance the test codes with wider test coverage
    johnnychen94 committed Jul 25, 2019
    Configuration menu
    Copy the full SHA
    1a0e2bb View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    c012f35 View commit details
    Browse the repository at this point in the history
  12. refactor Intermodes using the functor API

    This is a PR-commit for PR
    #29 that
    refactors the whole codebase to use the new functor API, which is
    discussed in more details in
    #26 and
    explained in my [GSoC 2019
    blog](https://nextjournal.com/johnnychen94/the-principles-of-imagesjl-part-i)
    
    Changes:
    
    * support `Color3` input
    * move implementations into functor
    * enhance the test codes with wider test coverage
    johnnychen94 committed Jul 25, 2019
    Configuration menu
    Copy the full SHA
    a993c98 View commit details
    Browse the repository at this point in the history
  13. refactor Otsu using the functor API

    This is a PR-commit for PR
    #29 that
    refactors the whole codebase to use the new functor API, which is
    discussed in more details in
    #26 and
    explained in my [GSoC 2019
    blog](https://nextjournal.com/johnnychen94/the-principles-of-imagesjl-part-i)
    
    Changes:
    
    * support `Color3` input
    * move implementations into functor
    * enhance the test codes with wider test coverage
    johnnychen94 committed Jul 25, 2019
    Configuration menu
    Copy the full SHA
    675077c View commit details
    Browse the repository at this point in the history
  14. refactor UnimodalRosin using the functor API

    This is a PR-commit for PR
    #29 that
    refactors the whole codebase to use the new functor API, which is
    discussed in more details in
    #26 and
    explained in my [GSoC 2019
    blog](https://nextjournal.com/johnnychen94/the-principles-of-imagesjl-part-i)
    
    Changes:
    
    * support `Color3` input
    * move implementations into functor
    * enhance the test codes with wider test coverage
    johnnychen94 committed Jul 25, 2019
    Configuration menu
    Copy the full SHA
    35d34f2 View commit details
    Browse the repository at this point in the history
  15. refactor Yen using the functor API

    This is a PR-commit for PR
    #29 that
    refactors the whole codebase to use the new functor API, which
    is discussed in more details in
    #26 and
    explained in my [GSoC 2019
    blog](https://nextjournal.com/johnnychen94/the-principles-of-imagesjl-part-i)
    
    Changes:
    
    * support `Color3` input
    * move implementations into functor
    * enhance the test codes with wider test coverage
    johnnychen94 committed Jul 25, 2019
    Configuration menu
    Copy the full SHA
    aa17759 View commit details
    Browse the repository at this point in the history

Commits on Jul 26, 2019

  1. Merge pull request #40 from johnnychen94/yen

    Refactor Yen using the functor API
    zygmuntszpak authored Jul 26, 2019
    Configuration menu
    Copy the full SHA
    fd7eda4 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    4cef748 View commit details
    Browse the repository at this point in the history
  3. Merge pull request #38 from johnnychen94/otsu

    Refactor Otsu using the functor API
    zygmuntszpak authored Jul 26, 2019
    Configuration menu
    Copy the full SHA
    c83ee71 View commit details
    Browse the repository at this point in the history
  4. Merge pull request #37 from johnnychen94/moments

    Refactor Moments using the functor API
    zygmuntszpak authored Jul 26, 2019
    Configuration menu
    Copy the full SHA
    a804365 View commit details
    Browse the repository at this point in the history
  5. Merge pull request #36 from johnnychen94/minimum

    Refactor MinimumIntermodes using functor API
    zygmuntszpak authored Jul 26, 2019
    Configuration menu
    Copy the full SHA
    9baae2c View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    c68fde4 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    f333669 View commit details
    Browse the repository at this point in the history
  8. Merge pull request #33 from johnnychen94/entropy

    Refactor Entropy using the functor API
    zygmuntszpak authored Jul 26, 2019
    Configuration menu
    Copy the full SHA
    e5be14a View commit details
    Browse the repository at this point in the history
  9. refactor UnimodalRosin using the functor API (#39)

    refactor UnimodalRosin using the functor API
    johnnychen94 authored Jul 26, 2019
    Configuration menu
    Copy the full SHA
    be33df6 View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    898d66a View commit details
    Browse the repository at this point in the history
  11. refactor Intermodes using the functor API (#34)

    refactor Intermodes using the functor API
    johnnychen94 authored Jul 26, 2019
    Configuration menu
    Copy the full SHA
    2951a80 View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    36c8f13 View commit details
    Browse the repository at this point in the history
  13. refactor Balanced using the functor API (#32)

    refactor Balanced using the functor API
    johnnychen94 authored Jul 26, 2019
    Configuration menu
    Copy the full SHA
    aa512f2 View commit details
    Browse the repository at this point in the history
  14. Configuration menu
    Copy the full SHA
    bf825c2 View commit details
    Browse the repository at this point in the history
  15. refactor MinimumError using functor API (#35)

    refactor MinimumError using functor API
    johnnychen94 authored Jul 26, 2019
    Configuration menu
    Copy the full SHA
    07704cb View commit details
    Browse the repository at this point in the history

Commits on Jul 29, 2019

  1. Configuration menu
    Copy the full SHA
    88202fe View commit details
    Browse the repository at this point in the history
  2. explicitly return the out image in Niblack

    Otherwise it would return `nothing`
    johnnychen94 committed Jul 29, 2019
    Configuration menu
    Copy the full SHA
    94f6ad8 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    b4333f1 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    d249ad8 View commit details
    Browse the repository at this point in the history

Commits on Jul 30, 2019

  1. update documentation

    johnnychen94 committed Jul 30, 2019
    Configuration menu
    Copy the full SHA
    1c67de8 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    6ad141f View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    b8b5569 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    cfcf746 View commit details
    Browse the repository at this point in the history
  5. replace recommend_size with function AdaptiveThreshold (closes #45)

    * AdaptiveThreshold: infer the window_size from img during construction
    
    * Niblack: revert the deprecation on window_size
    johnnychen94 authored Jul 30, 2019
    Configuration menu
    Copy the full SHA
    59a587d View commit details
    Browse the repository at this point in the history

Commits on Jul 31, 2019

  1. Configuration menu
    Copy the full SHA
    1fe6057 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    46e932e View commit details
    Browse the repository at this point in the history
  3. folder organization

    johnnychen94 committed Jul 31, 2019
    Configuration menu
    Copy the full SHA
    125c3e4 View commit details
    Browse the repository at this point in the history