refactor Moments using the functor API #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a PR-commit for PR #29 that refactors the whole codebase to use the new functor API, which is discussed in more details in #26 and explained in my [GSoC 2019 blog](https://nextjournal.com/johnnychen94/the-principles-of-imagesjl-part-i) Changes: * support `Color3` input * move implementations into functor * enhance the test codes with wider test coverage
16 tasks
Codecov Report
@@ Coverage Diff @@
## api #37 +/- ##
==========================================
+ Coverage 37.42% 41.27% +3.85%
==========================================
Files 20 20
Lines 171 172 +1
==========================================
+ Hits 64 71 +7
+ Misses 107 101 -6
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a PR-commit for PR #29 that refactors the whole codebase to use the new functor API, which is discussed in more details in #26 and explained in my GSoC 2019 blog
Changes:
Color3input