Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor Sauvola using the functor API #43

Merged
merged 1 commit into from
Jul 29, 2019
Merged

refactor Sauvola using the functor API #43

merged 1 commit into from
Jul 29, 2019

Conversation

johnnychen94
Copy link
Member

This PR is done in the same manner as #42 except that:

I didn't move window_size out of Sauvola according to #41

This PR is done in the same manner as #42 except that:

I didn't move `window_size` out of Sauvola according to #41
@codecov
Copy link

codecov bot commented Jul 29, 2019

Codecov Report

Merging #43 into api will increase coverage by 8.62%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##              api      #43      +/-   ##
==========================================
+ Coverage   80.31%   88.94%   +8.62%     
==========================================
  Files          20       20              
  Lines         188      190       +2     
==========================================
+ Hits          151      169      +18     
+ Misses         37       21      -16
Impacted Files Coverage Δ
src/sauvola.jl 94.73% <100%> (+94.73%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 94f6ad8...a5e0b86. Read the comment docs.

@johnnychen94 johnnychen94 merged commit b4333f1 into JuliaImages:api Jul 29, 2019
@johnnychen94 johnnychen94 deleted the sauvola branch July 29, 2019 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant