Expect insets in common #586
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # compose/mpp/demo/src/commonMain/kotlin/androidx/compose/mpp/demo/App.kt # compose/mpp/demo/src/uikitMain/kotlin/androidx/compose/mpp/demo/main.uikit.kt
# Conflicts: # compose/mpp/demo/src/commonMain/kotlin/androidx/compose/mpp/demo/App.kt
igordmn
approved these changes
Jun 9, 2023
copybara-service bot
pushed a commit
to androidx/androidx
that referenced
this pull request
Jun 20, 2023
`WindowInsets` API is compatible with other platforms. Commonize insets API with iOS safe area that has been added to Compose Multiplatform. This change is required to make it available to use in the common source set. Proposed changes: - `expect`/`actual` for `WindowInsets` - Add stubs for desktop Upstreaming changes from JetBrains#586 Test: n/a Change-Id: I82e60d7e8ad9c86b60abbabcf0407f6212a5c71d
eymar
pushed a commit
that referenced
this pull request
Aug 16, 2023
…ntation Test: ./gradlew paging:paging-testing:allTests This is an imported pull request from androidx#586. Resolves #586 Github-Pr-Head-Sha: 7250175 GitOrigin-RevId: 4ec4136 Change-Id: Ic2d81933a14555b0d8ca862437189aebbe6956d6
igordmn
pushed a commit
that referenced
this pull request
Nov 15, 2023
* Expect WindowInsets in commonMain * Move app layout mpp example to common * Copy comments to common
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Commonize insets from Android and iOS (introduced in #577)
expect/actualforWindowInsetsnotMobileinstead ofdesktopMain+jsWasmMain+macosMainTesting
Test: run mpp demo