Insets on iOS #577
Merged
Insets on iOS #577
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mazunin-v-jb
approved these changes
May 24, 2023
...ndation-layout/src/uikitMain/kotlin/androidx/compose/foundation/layout/WindowInsets.uikit.kt
Outdated
Show resolved
Hide resolved
mazunin-v-jb
approved these changes
May 24, 2023
MatkovIvan
reviewed
May 24, 2023
...ndation-layout/src/uikitMain/kotlin/androidx/compose/foundation/layout/WindowInsets.uikit.kt
Outdated
Show resolved
Hide resolved
...ndation-layout/src/uikitMain/kotlin/androidx/compose/foundation/layout/WindowInsets.uikit.kt
Outdated
Show resolved
Hide resolved
...ndation-layout/src/uikitMain/kotlin/androidx/compose/foundation/layout/WindowInsets.uikit.kt
Outdated
Show resolved
Hide resolved
...ndation-layout/src/uikitMain/kotlin/androidx/compose/foundation/layout/WindowInsets.uikit.kt
Outdated
Show resolved
Hide resolved
| */ | ||
| val WindowInsets.Companion.systemGestures: WindowInsets | ||
| @Composable | ||
| get() = layoutMargins // the same as iosSafeArea.add(WindowInsets(left = 16.dp, right = 16.dp)) |
There was a problem hiding this comment.
As discussed, it's better to recheck this. Probably const is better
There was a problem hiding this comment.
Do you think that it may be better for performance reasons?
There was a problem hiding this comment.
It's not about performans, but about possible change in future
There was a problem hiding this comment.
I think we can postpone it
compose/mpp/demo/src/uikitMain/kotlin/androidx/compose/mpp/demo/main.uikit.kt
Outdated
Show resolved
Hide resolved
| import androidx.compose.ui.main.defaultUIKitMain | ||
| import androidx.compose.ui.window.ComposeUIViewController | ||
|
|
||
| fun main() { | ||
| defaultUIKitMain("ComposeDemo", ComposeUIViewController { | ||
| val app = remember { App() } | ||
| app.Content() | ||
| IosDemo() |
There was a problem hiding this comment.
In mpp we usually add some new sample as a page. Why it cannot be done in this way?
There was a problem hiding this comment.
Compose Multiplatform Demo already has Scaffold with smaller area of content. For Insets sample, we need fullscreen access.
compose/ui/ui/src/uikitMain/kotlin/androidx/compose/ui/uikit/Insets.uikit.kt
Outdated
Show resolved
Hide resolved
| } ?: error("Can't find orientation rawValue $orientation in enum InterfaceOrientation") | ||
| } | ||
|
|
||
| fun getStatusBarOrientation(): InterfaceOrientation = |
There was a problem hiding this comment.
Please add comments/docs for public API
compose/ui/ui/src/uikitMain/kotlin/androidx/compose/ui/uikit/KeyboardOverlapHeight.uikit.kt
Outdated
Show resolved
Hide resolved
…oidx/compose/foundation/layout/WindowInsets.uikit.kt Co-authored-by: Ivan Matkov <ivan.matkov@jetbrains.com>
…oidx/compose/foundation/layout/WindowInsets.uikit.kt Co-authored-by: Ivan Matkov <ivan.matkov@jetbrains.com>
…oidx/compose/foundation/layout/WindowInsets.uikit.kt Co-authored-by: Ivan Matkov <ivan.matkov@jetbrains.com>
MatkovIvan
approved these changes
May 26, 2023
pjBooms
approved these changes
May 26, 2023
Merged
igordmn
pushed a commit
that referenced
this pull request
Jul 10, 2023
Test: ./gradlew test connectedCheck Bug: 270612487 This is an imported pull request from androidx#577. Resolves #577 Github-Pr-Head-Sha: 62541e8 GitOrigin-RevId: 4918bcf Change-Id: Ie1d1b4ce9aabfeb78a75b09c932bbad5dae95d49
igordmn
pushed a commit
that referenced
this pull request
Jan 30, 2024
API is the same as for Android WindowInsets.Companion.concreteInsetsName
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added WindowInsets to iOS