Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix top bar for iOS #2744

Closed
igordmn opened this issue Feb 14, 2023 · 4 comments
Closed

Fix top bar for iOS #2744

igordmn opened this issue Feb 14, 2023 · 4 comments
Assignees
Labels
enhancement New feature or request ios

Comments

@igordmn
Copy link
Collaborator

igordmn commented Feb 14, 2023

Currently iOS samples use constant offset from the top to show the content.

Instead we should calculate top bar height (that is different for different devices) and use it as offset.

The calculation should be done automatically and embedded to androidx.compose.ui.window.Application.

We probably also need a new parameter - topBarColor in this function to automatically color the top bar.

Then all iOS samples should b fixed to remove current constant offset workaround.

@igordmn igordmn added enhancement New feature or request ios labels Feb 14, 2023
@mazunin-v-jb mazunin-v-jb self-assigned this Feb 14, 2023
@mipastgt
Copy link

Isn't that approach a little bit too simplistic? See for example: https://blog.felgo.com/cross-platform-app-development/notch-developer-guide-ios-android

@dima-avdeev-jb
Copy link
Contributor

Useful links.
How it works on Android: /Users/dim/Desktop/github/dima-avdeev-jb/android-intets
Experiments on iOS: JetBrains/compose-multiplatform-core@36d9f9a

@dima-avdeev-jb
Copy link
Contributor

@okushnikov
Copy link
Collaborator

Please check the following ticket on YouTrack for follow-ups to this issue. GitHub issues will be closed in the coming weeks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request ios
Projects
None yet
Development

No branches or pull requests

5 participants