-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Indicate vertex-centric index used in profile step #2283
Comments
Thank you for considering this enhancement.
We already have a list of conditions considered for backend-query, sample: |
Fixes JanusGraph#898, JanusGraph#2283, JanusGraph#2285 Signed-off-by: Boxuan Li <liboxuan@connect.hku.hk>
Fixes JanusGraph#898, JanusGraph#2283, JanusGraph#2285 Signed-off-by: Boxuan Li <liboxuan@connect.hku.hk>
Fixes JanusGraph#898, JanusGraph#2283, JanusGraph#2285 Signed-off-by: Boxuan Li <liboxuan@connect.hku.hk>
Fixes JanusGraph#898, JanusGraph#2283, JanusGraph#2285 Signed-off-by: Boxuan Li <liboxuan@connect.hku.hk>
Fixes JanusGraph#898, JanusGraph#2283, JanusGraph#2285 Signed-off-by: Boxuan Li <liboxuan@connect.hku.hk>
Fixes JanusGraph#898, JanusGraph#2283, JanusGraph#2285 Signed-off-by: Boxuan Li <liboxuan@connect.hku.hk>
Fixes JanusGraph#898, JanusGraph#2283, JanusGraph#2285 Signed-off-by: Boxuan Li <liboxuan@connect.hku.hk>
Fixes JanusGraph#898, JanusGraph#2283, JanusGraph#2285 Signed-off-by: Boxuan Li <liboxuan@connect.hku.hk>
Fixes JanusGraph#898, JanusGraph#2283, JanusGraph#2285 Signed-off-by: Boxuan Li <liboxuan@connect.hku.hk>
Fixes JanusGraph#898, JanusGraph#2283, JanusGraph#2285 Signed-off-by: Boxuan Li <liboxuan@connect.hku.hk>
1. Add toString() method to SliceQuery to indicate which vertex-centric index is used in edge queries. 2. Indicate "GraphCentricQuery" and "VertexCentricQuery" in profiler if applicable. Previously they were incorrectly merged, causing corrupted annotations. 3. Indicate "constructGraphCentricQuery" phase in profiler rather than a vague "optimization" annotation, if applicable. 4. Fix corrupted annotations caused by nested profile flattening issue. Now AND/OR nesting is flattened only if it does not have siblings. Fixes JanusGraph#898, JanusGraph#2283, JanusGraph#2285 Signed-off-by: Boxuan Li <liboxuan@connect.hku.hk>
1. Add toString() method to SliceQuery to indicate which vertex-centric index is used in edge queries. 2. Indicate "GraphCentricQuery" and "VertexCentricQuery" in profiler if applicable. Previously they were incorrectly merged, causing corrupted annotations. 3. Indicate "constructGraphCentricQuery" phase in profiler rather than a vague "optimization" annotation, if applicable. 4. Fix corrupted annotations caused by nested profile flattening issue. Now AND/OR nesting is flattened only if it does not have siblings. Fixes JanusGraph#898, JanusGraph#2283, JanusGraph#2285 Signed-off-by: Boxuan Li <liboxuan@connect.hku.hk>
1. Add toString() method to SliceQuery to indicate which vertex-centric index is used in edge queries. 2. Indicate "GraphCentricQuery" and "VertexCentricQuery" in profiler if applicable. Previously they were incorrectly merged, causing corrupted annotations. 3. Indicate "constructGraphCentricQuery" phase in profiler rather than a vague "optimization" annotation, if applicable. 4. Fix corrupted annotations caused by nested profile flattening issue. Now AND/OR nesting is flattened only if it does not have siblings. Fixes JanusGraph#898, JanusGraph#2283, JanusGraph#2285 Signed-off-by: Boxuan Li <liboxuan@connect.hku.hk>
Thanks you so much for the effort,... desperate to try that asap. I have a feeling that more questions will pop up, like why indexes are not used ;-) Christopher |
1. Add toString() method to SliceQuery to indicate which vertex-centric index is used in edge queries. 2. Indicate "GraphCentricQuery" and "VertexCentricQuery" in profiler if applicable. Previously they were incorrectly merged, causing corrupted annotations. 3. Indicate "constructGraphCentricQuery" phase in profiler rather than a vague "optimization" annotation, if applicable. 4. Fix corrupted annotations caused by nested profile flattening issue. Now AND/OR nesting is flattened only if it does not have siblings. Fixes JanusGraph#898, JanusGraph#2283, JanusGraph#2285 Signed-off-by: Boxuan Li <liboxuan@connect.hku.hk>
1. Add toString() method to SliceQuery to indicate which vertex-centric index is used in edge queries. 2. Indicate "GraphCentricQuery" and "VertexCentricQuery" in profiler if applicable. Previously they were incorrectly merged, causing corrupted annotations. 3. Indicate "constructGraphCentricQuery" phase in profiler rather than a vague "optimization" annotation, if applicable. 4. Fix corrupted annotations caused by nested profile flattening issue. Now AND/OR nesting is flattened only if it does not have siblings. 5. Remove backend-query subgroup to reduce nesting levels in profiler result. Now whether a backend-query is fired can be inferred from "isCached" annotation. 6. Remove fullscan subgroup to reduce nesting levels in profiler result. Now whether a full scan is done can be inferred from "fullscan" annotation. Fixes JanusGraph#898, JanusGraph#2283, JanusGraph#2285 Signed-off-by: Boxuan Li <liboxuan@connect.hku.hk>
Closes JanusGraph#898, JanusGraph#2283 Signed-off-by: Boxuan Li <liboxuan@connect.hku.hk>
Closes JanusGraph#898, JanusGraph#2283 Signed-off-by: Boxuan Li <liboxuan@connect.hku.hk>
Closes JanusGraph#898, JanusGraph#2283 Signed-off-by: Boxuan Li <liboxuan@connect.hku.hk>
Fixed by #2360 |
Composite indexes and mixed indexes, if used, would show up in the profiler result. However, profile() step does not indicate if and which vertex-centric index is used.
See https://groups.google.com/g/janusgraph-users/c/SqjYfsEInrQ/m/RDWALyDMAgAJ
Related issue: #898
The text was updated successfully, but these errors were encountered: