-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Profiler annotations are wrong when there are multiple backend queries #2285
Comments
li-boxuan
added a commit
to li-boxuan/janusgraph
that referenced
this issue
Dec 20, 2020
Fixes JanusGraph#898, JanusGraph#2283, JanusGraph#2285 Signed-off-by: Boxuan Li <liboxuan@connect.hku.hk>
li-boxuan
added a commit
to li-boxuan/janusgraph
that referenced
this issue
Dec 20, 2020
Fixes JanusGraph#898, JanusGraph#2283, JanusGraph#2285 Signed-off-by: Boxuan Li <liboxuan@connect.hku.hk>
li-boxuan
added a commit
to li-boxuan/janusgraph
that referenced
this issue
Dec 20, 2020
Fixes JanusGraph#898, JanusGraph#2283, JanusGraph#2285 Signed-off-by: Boxuan Li <liboxuan@connect.hku.hk>
li-boxuan
added a commit
to li-boxuan/janusgraph
that referenced
this issue
Dec 27, 2020
Fixes JanusGraph#898, JanusGraph#2283, JanusGraph#2285 Signed-off-by: Boxuan Li <liboxuan@connect.hku.hk>
li-boxuan
added a commit
to li-boxuan/janusgraph
that referenced
this issue
Dec 27, 2020
Fixes JanusGraph#898, JanusGraph#2283, JanusGraph#2285 Signed-off-by: Boxuan Li <liboxuan@connect.hku.hk>
li-boxuan
added a commit
to li-boxuan/janusgraph
that referenced
this issue
Dec 27, 2020
Fixes JanusGraph#898, JanusGraph#2283, JanusGraph#2285 Signed-off-by: Boxuan Li <liboxuan@connect.hku.hk>
li-boxuan
added a commit
to li-boxuan/janusgraph
that referenced
this issue
Dec 28, 2020
Fixes JanusGraph#898, JanusGraph#2283, JanusGraph#2285 Signed-off-by: Boxuan Li <liboxuan@connect.hku.hk>
li-boxuan
added a commit
to li-boxuan/janusgraph
that referenced
this issue
Jan 3, 2021
Fixes JanusGraph#898, JanusGraph#2283, JanusGraph#2285 Signed-off-by: Boxuan Li <liboxuan@connect.hku.hk>
li-boxuan
added a commit
to li-boxuan/janusgraph
that referenced
this issue
Jan 5, 2021
Fixes JanusGraph#898, JanusGraph#2283, JanusGraph#2285 Signed-off-by: Boxuan Li <liboxuan@connect.hku.hk>
li-boxuan
added a commit
to li-boxuan/janusgraph
that referenced
this issue
Jan 5, 2021
Fixes JanusGraph#898, JanusGraph#2283, JanusGraph#2285 Signed-off-by: Boxuan Li <liboxuan@connect.hku.hk>
li-boxuan
added a commit
to li-boxuan/janusgraph
that referenced
this issue
Jan 9, 2021
1. Add toString() method to SliceQuery to indicate which vertex-centric index is used in edge queries. 2. Indicate "GraphCentricQuery" and "VertexCentricQuery" in profiler if applicable. Previously they were incorrectly merged, causing corrupted annotations. 3. Indicate "constructGraphCentricQuery" phase in profiler rather than a vague "optimization" annotation, if applicable. 4. Fix corrupted annotations caused by nested profile flattening issue. Now AND/OR nesting is flattened only if it does not have siblings. Fixes JanusGraph#898, JanusGraph#2283, JanusGraph#2285 Signed-off-by: Boxuan Li <liboxuan@connect.hku.hk>
li-boxuan
added a commit
to li-boxuan/janusgraph
that referenced
this issue
Jan 9, 2021
1. Add toString() method to SliceQuery to indicate which vertex-centric index is used in edge queries. 2. Indicate "GraphCentricQuery" and "VertexCentricQuery" in profiler if applicable. Previously they were incorrectly merged, causing corrupted annotations. 3. Indicate "constructGraphCentricQuery" phase in profiler rather than a vague "optimization" annotation, if applicable. 4. Fix corrupted annotations caused by nested profile flattening issue. Now AND/OR nesting is flattened only if it does not have siblings. Fixes JanusGraph#898, JanusGraph#2283, JanusGraph#2285 Signed-off-by: Boxuan Li <liboxuan@connect.hku.hk>
li-boxuan
added a commit
to li-boxuan/janusgraph
that referenced
this issue
Jan 10, 2021
1. Add toString() method to SliceQuery to indicate which vertex-centric index is used in edge queries. 2. Indicate "GraphCentricQuery" and "VertexCentricQuery" in profiler if applicable. Previously they were incorrectly merged, causing corrupted annotations. 3. Indicate "constructGraphCentricQuery" phase in profiler rather than a vague "optimization" annotation, if applicable. 4. Fix corrupted annotations caused by nested profile flattening issue. Now AND/OR nesting is flattened only if it does not have siblings. Fixes JanusGraph#898, JanusGraph#2283, JanusGraph#2285 Signed-off-by: Boxuan Li <liboxuan@connect.hku.hk>
li-boxuan
added a commit
to li-boxuan/janusgraph
that referenced
this issue
Jan 14, 2021
1. Add toString() method to SliceQuery to indicate which vertex-centric index is used in edge queries. 2. Indicate "GraphCentricQuery" and "VertexCentricQuery" in profiler if applicable. Previously they were incorrectly merged, causing corrupted annotations. 3. Indicate "constructGraphCentricQuery" phase in profiler rather than a vague "optimization" annotation, if applicable. 4. Fix corrupted annotations caused by nested profile flattening issue. Now AND/OR nesting is flattened only if it does not have siblings. Fixes JanusGraph#898, JanusGraph#2283, JanusGraph#2285 Signed-off-by: Boxuan Li <liboxuan@connect.hku.hk>
li-boxuan
added a commit
to li-boxuan/janusgraph
that referenced
this issue
Jan 14, 2021
1. Add toString() method to SliceQuery to indicate which vertex-centric index is used in edge queries. 2. Indicate "GraphCentricQuery" and "VertexCentricQuery" in profiler if applicable. Previously they were incorrectly merged, causing corrupted annotations. 3. Indicate "constructGraphCentricQuery" phase in profiler rather than a vague "optimization" annotation, if applicable. 4. Fix corrupted annotations caused by nested profile flattening issue. Now AND/OR nesting is flattened only if it does not have siblings. 5. Remove backend-query subgroup to reduce nesting levels in profiler result. Now whether a backend-query is fired can be inferred from "isCached" annotation. 6. Remove fullscan subgroup to reduce nesting levels in profiler result. Now whether a full scan is done can be inferred from "fullscan" annotation. Fixes JanusGraph#898, JanusGraph#2283, JanusGraph#2285 Signed-off-by: Boxuan Li <liboxuan@connect.hku.hk>
9 tasks
li-boxuan
added a commit
to li-boxuan/janusgraph
that referenced
this issue
Jan 30, 2021
Currently, when there is more than one backend query, annotations (condition, orders, isFitted, isOrdered, query, index) of the last one overwrites previous annotations in the profiling result. This commit fixes this problem by avoiding flattening AND/OR query groups. The drawback of this commit is those groups (AND-query, OR-query) are not timed due to technical difficulty, which is left as future work. Fixes JanusGraph#2285 Signed-off-by: Boxuan Li <liboxuan@connect.hku.hk>
9 tasks
li-boxuan
added a commit
to li-boxuan/janusgraph
that referenced
this issue
Feb 3, 2021
Currently, when there is more than one backend query, annotations (condition, orders, isFitted, isOrdered, query, index) of the last one overwrites previous annotations in the profiling result. This commit fixes this problem by avoiding flattening AND/OR query groups. The drawback of this commit is those groups (AND-query, OR-query) are not timed due to technical difficulty, which is left as future work. Fixes JanusGraph#2285 Signed-off-by: Boxuan Li <liboxuan@connect.hku.hk>
li-boxuan
added a commit
to li-boxuan/janusgraph
that referenced
this issue
Feb 4, 2021
Currently, when there is more than one backend query, annotations (condition, orders, isFitted, isOrdered, query, index) of the last one overwrites previous annotations in the profiling result. This commit fixes this problem by avoiding flattening AND/OR query groups. The drawback of this commit is those groups (AND-query, OR-query) are not timed due to technical difficulty, which is left as future work. Fixes JanusGraph#2285 Signed-off-by: Boxuan Li <liboxuan@connect.hku.hk>
li-boxuan
added a commit
to li-boxuan/janusgraph
that referenced
this issue
Feb 25, 2021
Currently, when there is more than one backend query, annotations (condition, orders, isFitted, isOrdered, query, index) of the last one overwrites previous annotations in the profiling result. This commit fixes this problem by avoiding flattening AND/OR query groups. The drawback of this commit is those groups (AND-query, OR-query) are not timed due to technical difficulty, which is left as future work. Fixes JanusGraph#2285 Signed-off-by: Boxuan Li <liboxuan@connect.hku.hk>
li-boxuan
added a commit
that referenced
this issue
Feb 27, 2021
Currently, when there is more than one backend query, annotations (condition, orders, isFitted, isOrdered, query, index) of the last one overwrites previous annotations in the profiling result. This commit fixes this problem by avoiding flattening AND/OR query groups. The drawback of this commit is those groups (AND-query, OR-query) are not timed due to technical difficulty, which is left as future work. Fixes #2285 Signed-off-by: Boxuan Li <liboxuan@connect.hku.hk>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
For confirmed bugs, please report:
When there is more than one backend query, annotations (condition, orders, isFitted, isOrdered, query, index) of the last one overwrites previous annotations.
Note the following part
only represents the second backend-query.
Same issue:
The text was updated successfully, but these errors were encountered: