Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Indicate vertex-centric index usage in profiler result #2360

Merged

Conversation

li-boxuan
Copy link
Member

Closes #898, #2283


Thank you for contributing to JanusGraph!

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

For all changes:

  • Is there an issue associated with this PR? Is it referenced in the commit message?
  • Does your PR body contain #xyz where xyz is the issue number you are trying to resolve?
  • Has your PR been rebased against the latest commit within the target branch (typically master)?
  • Is your initial contribution a single, squashed commit?

For code changes:

  • Have you written and/or updated unit tests to verify your changes?
  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE.txt file, including the main LICENSE.txt file in the root of this repository?
  • If applicable, have you updated the NOTICE.txt file, including the main NOTICE.txt file found in the root of this repository?

For documentation related changes:

  • Have you ensured that format looks appropriate for the output in which it is rendered?

@janusgraph-bot janusgraph-bot added the cla: external Externally-managed CLA label Jan 15, 2021
@codecov-io
Copy link

codecov-io commented Jan 15, 2021

Codecov Report

Merging #2360 (18cc6b0) into master (6fb94b8) will increase coverage by 0.00%.
The diff coverage is 90.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #2360   +/-   ##
=========================================
  Coverage     70.34%   70.35%           
- Complexity     7725     7731    +6     
=========================================
  Files           681      681           
  Lines         29865    29873    +8     
  Branches       4824     4825    +1     
=========================================
+ Hits          21010    21016    +6     
- Misses         6335     6339    +4     
+ Partials       2520     2518    -2     
Impacted Files Coverage Δ Complexity Δ
...raph/diskstorage/keycolumnvalue/KeySliceQuery.java 72.22% <0.00%> (ø) 9.00 <0.00> (ø)
...usgraph/graphdb/query/graph/GraphCentricQuery.java 66.66% <ø> (ø) 16.00 <0.00> (ø)
...anusgraph/graphdb/query/profile/QueryProfiler.java 89.65% <ø> (ø) 10.00 <0.00> (ø)
...usgraph/diskstorage/keycolumnvalue/SliceQuery.java 79.16% <100.00%> (+4.16%) 27.00 <3.00> (+3.00)
...rg/janusgraph/graphdb/database/EdgeSerializer.java 80.60% <100.00%> (+0.38%) 79.00 <0.00> (+1.00)
...usgraph/diskstorage/PermanentBackendException.java 66.66% <0.00%> (-33.34%) 2.00% <0.00%> (-1.00%)
...a/org/janusgraph/util/system/BackgroundThread.java 66.66% <0.00%> (-4.77%) 6.00% <0.00%> (-2.00%)
...ph/diskstorage/hbase/HBaseKeyColumnValueStore.java 76.22% <0.00%> (-2.46%) 20.00% <0.00%> (ø%)
...a/org/janusgraph/diskstorage/log/kcvs/KCVSLog.java 84.49% <0.00%> (-0.31%) 44.00% <0.00%> (+1.00%) ⬇️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6fb94b8...18cc6b0. Read the comment docs.

Closes JanusGraph#898, JanusGraph#2283

Signed-off-by: Boxuan Li <liboxuan@connect.hku.hk>
@li-boxuan li-boxuan force-pushed the feature/show-vci-index-in-profiler branch from 2acdfeb to 18cc6b0 Compare January 16, 2021 02:28
Copy link
Contributor

@farodin91 farodin91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@li-boxuan li-boxuan merged commit 74cf3bd into JanusGraph:master Jan 17, 2021
@li-boxuan li-boxuan deleted the feature/show-vci-index-in-profiler branch January 17, 2021 02:33
@li-boxuan li-boxuan linked an issue Jan 18, 2021 that may be closed by this pull request
@li-boxuan li-boxuan added this to the Release v0.6.0 milestone Jan 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: external Externally-managed CLA
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Indicate vertex-centric index used in profile step Add toString to KeySliceQuery for profile
4 participants