Skip to content

Removed some random unused stuff #377

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 21, 2015
Merged

Conversation

oscargus
Copy link
Contributor

Removed unused variables, methods, and classes that I happened to stumble upon.

@koppor
Copy link
Member

koppor commented Nov 20, 2015

Looks OK. The only thing is TextAnalyzer. I think, this could need a more thorough check: It seems that this class can be used to parse plain text references. Would be an offline alternative to the FreeCite parsing. PRRV also seems to do parse text citations. I don't know, what's better, but I would not delete TextAnalyzer without having investigated alternative code. I understand that the current code is used nowhere. However, I would more like to put it into production than deleting it. For instance, the code could help at "Paste entries from plain text" when no internet connection is available.

@oscargus
Copy link
Contributor Author

OK! I'll figure out how to recover that file. Seemed like a waste to delete it, but since it wasn't used... If you have any feedback on JabRef#25 this is another case where we could throw away fully usable, non-trivial code, which is currently unused (except for a constructor, which in turn is unused).

@koppor
Copy link
Member

koppor commented Nov 21, 2015

I think, following steps should do the trick:

  1. git rebase -i "HEAD^"
  2. in the opened text file, replace pick by edit, save and close
  3. git gui
  4. select the file in the lower left box
  5. choose "Commit" -> "Unstage from Commit"
  6. select the file in the top box
  7. "Commit" -> "Revert changes", accept
  8. close git gui (no commit necessary)
  9. git rebase --continue

@oscargus oscargus force-pushed the removingunusedstuff branch from 25f21a7 to 3282596 Compare November 21, 2015 13:45
@oscargus
Copy link
Contributor Author

Great, that worked! (Except that I my GUI was in Swedish...) Thanks!

@koppor
Copy link
Member

koppor commented Nov 21, 2015

Change to English: set environment variable LANG to en. I personally don't like the German translation of git gui.

koppor added a commit that referenced this pull request Nov 21, 2015
@koppor koppor merged commit 52485d2 into JabRef:master Nov 21, 2015
@oscargus oscargus deleted the removingunusedstuff branch November 28, 2015 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants