JabRef · koppor · Nov 21, 2015 · Nov 21, 2015
diff --git a/src/main/java/net/sf/jabref/collab/ChangeScanner.java b/src/main/java/net/sf/jabref/collab/ChangeScanner.java
@@ -120,7 +120,7 @@ public void run() {
 
             scanEntries(sInMem, sInTemp, sOnDisk);
 
-            scanGroups(mdInMem, mdInTemp, mdOnDisk);
+            scanGroups(mdInTemp, mdOnDisk);
 
         } catch (IOException ex) {
             ex.printStackTrace();
@@ -515,7 +515,7 @@ private static BibtexString findString(BibtexDatabase base, String name, HashSet
      * This method only detects whether a change took place or not. It does not determine the type of change. This would
      * be possible, but difficult to do properly, so I rather only report the change.
      */
-    private void scanGroups(MetaData inMem, MetaData onTmp, MetaData onDisk) {
+    private void scanGroups(MetaData onTmp, MetaData onDisk) {
         final GroupTreeNode groupsTmp = onTmp.getGroups();
         final GroupTreeNode groupsDisk = onDisk.getGroups();
         if ((groupsTmp == null) && (groupsDisk == null)) {

diff --git a/src/main/java/net/sf/jabref/external/SynchronizeFileField.java b/src/main/java/net/sf/jabref/external/SynchronizeFileField.java
@@ -105,7 +105,6 @@ public void run() {
                 + (checkExisting ? sel.length : 0);
         panel.frame().setProgressBarMaximum(progressBarMax);
         int progress = 0;
-        int brokenLinks = 0;
         final NamedCompound ce = new NamedCompound(Localization.lang("Autoset %0 field", fieldName));
 
         //final OpenFileFilter off = Util.getFileFilterForField(fieldName);
@@ -217,7 +216,6 @@ public void run() {
                                 // Cancel
                                 break mainLoop;
                             }
-                            brokenLinks++;
                         }
 
                         // Unless we deleted this link, see if its file type is recognized:

diff --git a/src/main/java/net/sf/jabref/groups/GroupSelector.java b/src/main/java/net/sf/jabref/groups/GroupSelector.java
@@ -691,21 +691,6 @@ private void updateGroupContent(GroupTreeNode node) {
         }
     }
 
-    /**
-     * @param deletion != addition
-     */
-    public void updateGroupContentIfEnabled(boolean deletion) {
-        if ((groupsTree == null) || (groupsTree.getSelectionCount() == 0)) {
-            return;
-        }
-        if (!this.editModeIndicator) {
-            // add button selected
-            return;
-        }
-        GroupTreeNode curNode = (GroupTreeNode) (groupsTree.getSelectionPaths())[0].getLastPathComponent();
-        updateGroupContent(curNode);
-    }
-
     private void annotationEvent(GroupTreeNode node) {
         LOGGER.info("Performing annotation " + node);
         if (editModeIndicator) {
@@ -716,10 +701,6 @@ private void annotationEvent(GroupTreeNode node) {
         }
     }
 
-    //    private void annotationEvent() {
-    //        this.annotationEvent((GroupTreeNode) ((groupsTree.getSelectionPaths())[0].getLastPathComponent()));
-    //    }
-
     @Override
     public void valueChanged(TreeSelectionEvent e) {
         if (panel == null) // sorry, we're closed!
@@ -948,10 +929,6 @@ public NodeAction(String s) {
             super(s);
         }
 
-        public GroupTreeNode getNode() {
-            return m_node;
-        }
-
         public void setNode(GroupTreeNode node) {
             this.m_node = node;
         }

diff --git a/src/main/java/net/sf/jabref/gui/AttachFileDialog.java b/src/main/java/net/sf/jabref/gui/AttachFileDialog.java
@@ -1,4 +1,4 @@
-/*  Copyright (C) 2003-2011 JabRef contributors.
+/*  Copyright (C) 2003-2015 JabRef contributors.
     This program is free software; you can redistribute it and/or modify
     it under the terms of the GNU General Public License as published by
     the Free Software Foundation; either version 2 of the License, or
@@ -17,7 +17,6 @@
 
 import java.awt.BorderLayout;
 import java.awt.Dialog;
-import java.awt.Frame;
 import java.awt.event.ActionEvent;
 import java.awt.event.ActionListener;
 
@@ -57,17 +56,6 @@ public class AttachFileDialog extends JDialog {
     private final MetaData metaData;
     private boolean cancelled = true; // Default to true, so a pure close operation implies Cancel.
 
-
-    public AttachFileDialog(Frame parent, MetaData metaData, BibtexEntry entry, String fieldName) {
-        super(parent, true);
-        this.metaData = metaData;
-        this.entry = entry;
-        this.fieldName = fieldName;
-        this.editor = new TextField(fieldName, entry.getField(fieldName), false);
-
-        initGui();
-    }
-
     public AttachFileDialog(Dialog parent, MetaData metaData, BibtexEntry entry, String fieldName) {
         super(parent, true);
         this.metaData = metaData;

diff --git a/src/main/java/net/sf/jabref/gui/BibtexFields.java b/src/main/java/net/sf/jabref/gui/BibtexFields.java
@@ -236,7 +236,7 @@ private BibtexFields() {
         // collect all public fields for the PUBLIC_FIELDS array
         Vector<String> pFields = new Vector<>(fieldSet.size());
         for (BibtexSingleField sField : fieldSet.values()) {
-            if (sField.isPublic()) {
+            if (!sField.isPrivate()) {
                 pFields.add(sField.getFieldName());
                 // or export the complet BibtexSingleField ?
                 // BibtexSingleField.toString() { return fieldname ; }
@@ -561,14 +561,6 @@ public boolean isPrivate() {
             return isSet(BibtexSingleField.PRIVATE);
         }
 
-        public void setPublic() {
-            setFlag(false, BibtexSingleField.PRIVATE);
-        }
-
-        public boolean isPublic() {
-            return !isSet(BibtexSingleField.PRIVATE);
-        }
-
         public void setDisplayable(boolean value) {
             setFlag(value, BibtexSingleField.DISPLAYABLE);
         }

diff --git a/src/main/java/net/sf/jabref/gui/DuplicateResolverDialog.java b/src/main/java/net/sf/jabref/gui/DuplicateResolverDialog.java
@@ -199,10 +199,6 @@ private void buttonPressed(int button) {
         dispose();
     }
 
-    public boolean isBlocking() {
-        return block;
-    }
-
     public int getSelected() {
         return status;
     }

diff --git a/src/main/java/net/sf/jabref/gui/FieldSetComponent.java b/src/main/java/net/sf/jabref/gui/FieldSetComponent.java
@@ -281,18 +281,6 @@ void removeSelected() {
 
     }
 
-    public void activate() {
-        sel.requestFocus();
-    }
-
-    /**
-     * Returns true if there have been changes to the field list. Reports true
-     * if changes have been made, regardless of whether the changes cancel each other.
-     */
-    public boolean changesMade() {
-        return changesMade;
-    }
-
     /**
      * Return the current list.
      */
@@ -320,10 +308,6 @@ public void addAdditionActionListener(ActionListener l) {
         additionListeners.add(l);
     }
 
-    public void removeAdditionActionListener(ActionListener l) {
-        additionListeners.remove(l);
-    }
-
     public void addListDataListener(ListDataListener l) {
         listModel.addListDataListener(l);
         modelListeners.add(l);

diff --git a/src/main/java/net/sf/jabref/gui/FindUnlinkedFilesDialog.java b/src/main/java/net/sf/jabref/gui/FindUnlinkedFilesDialog.java
@@ -612,7 +612,7 @@ public void stateChanged(ChangeEvent e) {
                                 progressBarImporting.setString(counter + " of " + progressBarImporting.getMaximum());
                             }
                         }, errors);
-                importFinishedHandler(count, errors);
+                importFinishedHandler(errors);
             }
         });
 
@@ -622,7 +622,7 @@ public void stateChanged(ChangeEvent e) {
      *
      * @param errors
      */
-    private void importFinishedHandler(int count, List<String> errors) {
+    private void importFinishedHandler(List<String> errors) {
 
         if ((errors != null) && !errors.isEmpty()) {
 
@@ -1083,7 +1083,8 @@ private void createFileTypesCombobox() {
              * @see javax.swing.DefaultListCellRenderer#getListCellRendererComponent(javax.swing.JList, java.lang.Object, int, boolean, boolean)
              */
             @Override
-            public Component getListCellRendererComponent(JList list, Object value, int index, boolean isSelected, boolean cellHasFocus) {
+            public Component getListCellRendererComponent(JList<?> list, Object value, int index, boolean isSelected,
+                    boolean cellHasFocus) {
                 JLabel label = (JLabel) super.getListCellRendererComponent(list, value, index, isSelected, cellHasFocus);
                 if (value instanceof EntryFromFileCreator) {
                     EntryFromFileCreator creator = (EntryFromFileCreator) value;
@@ -1143,9 +1144,8 @@ public String toString() {
 
     public static class CheckableTreeNode extends DefaultMutableTreeNode {
 
-        private static final long serialVersionUID = -1131241777605570737L;
         private boolean isSelected;
-        private JCheckBox checkbox;
+        private final JCheckBox checkbox;
 
 
         public CheckableTreeNode(Object userObject) {
@@ -1160,14 +1160,6 @@ public JCheckBox getCheckbox() {
             return checkbox;
         }
 
-        /**
-         * @param checkbox
-         *            the checkbox to set
-         */
-        public void setCheckbox(JCheckBox checkbox) {
-            this.checkbox = checkbox;
-        }
-
         public void check() {
             setSelected(!isSelected);
         }

diff --git a/src/main/java/net/sf/jabref/gui/GUIGlobals.java b/src/main/java/net/sf/jabref/gui/GUIGlobals.java
@@ -189,20 +189,6 @@ public static void updateEntryEditorColors() {
         GUIGlobals.editorTextColor = JabRefPreferences.getInstance().getColor(JabRefPreferences.FIELD_EDITOR_TEXT_COLOR);
     }
 
-    /**
-     * returns the path to language independent help files
-     */
-    public static String getLocaleHelpPath() {
-        JabRefPreferences prefs = JabRefPreferences.getInstance();
-        String middle = prefs.get(JabRefPreferences.LANGUAGE) + '/';
-        if (middle.equals("en/")) {
-            middle = ""; // English in base help dir.
-        }
-
-        return GUIGlobals.helpPre + middle;
-    }
-
-
     /**
      * Perform initializations that are only used in graphical mode. This is to prevent
      * the "Xlib: connection to ":0.0" refused by server" error when access to the X server

diff --git a/src/main/java/net/sf/jabref/gui/TitleLabel.java b/src/main/java/net/sf/jabref/gui/TitleLabel.java