-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
Support searching references at Google Scholar & Semantic Scholar #14370
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Co-authored-by: Brandon Lau <1brandonlau@gmail.com> Signed-off-by: subhramit <subhramit.bb@live.in>
Signed-off-by: subhramit <subhramit.bb@live.in>
Signed-off-by: subhramit <subhramit.bb@live.in>
Signed-off-by: subhramit <subhramit.bb@live.in>
Signed-off-by: subhramit <subhramit.bb@live.in>
Signed-off-by: subhramit <subhramit.bb@live.in>
Signed-off-by: subhramit <subhramit.bb@live.in>
Signed-off-by: subhramit <subhramit.bb@live.in>
Signed-off-by: subhramit <subhramit.bb@live.in>
Signed-off-by: subhramit <subhramit.bb@live.in>
Signed-off-by: subhramit <subhramit.bb@live.in>
Signed-off-by: subhramit <subhramit.bb@live.in>
Signed-off-by: subhramit <subhramit.bb@live.in>
Signed-off-by: subhramit <subhramit.bb@live.in>
Signed-off-by: subhramit <subhramit.bb@live.in>
Signed-off-by: subhramit <subhramit.bb@live.in>
Signed-off-by: subhramit <subhramit.bb@live.in>
Signed-off-by: subhramit <subhramit.bb@live.in>
Signed-off-by: subhramit <subhramit.bb@live.in>
|
Semantic Scholar has different schema for authors. Instead of single |
|
Gosh I did something with submodules |
|
I don't know where I got this java packaging |
|
Sorry, but I'm unable to fix the code right now. Hope there are issues only in code formatting |
|
But I wonder, can I parse a list of authors by just separating by |
This is BibTeX standard. They define the letters Just use |
Maybe, you tried out #14124, where we had that submodule for a short time. |
|
Maybe, but now everything should be alright with the submodules |
|
I converted to draft, because OpenRewrite fails. |
| void getSemanticScholarSearchURLIncludesAuthor() { | ||
| BibEntry entry = createEntryWithTitleAndAuthor("Quantum Computing", "Alice Smith"); | ||
| Optional<String> url = linkCreator.getSemanticScholarSearchURL(entry); | ||
| System.err.println(url.get()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No system.err println
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OMG SORRY
I should've deleted this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OMG SORRY
I should've deleted this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Our architecture test needs to be adapted.
LOGGER.debug would have been the right replacement 😅
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Our architecture test needs to be adapted.
LOGGER.debug would have been the right replacement 😅
Signed-off-by: subhramit <subhramit.bb@live.in>
Follow-up to #13153
Closes #12268
Addresses review comments, makes a few enhancements, cleans up some existing code and resolves merge conflicts.
URLUtil,URLChecker,).LinkedFileDescription copied from the previous PR (and slightly enhanced):
Summary of Changes
This PR adds a new "Search Google Scholar" feature to JabRef, similar to the existing "Search ShortScience" functionality. The feature allows users to quickly search for a selected entry's title in Google Scholar directly from the main table's context menu. The search engines are moved under the "Search..." tab in the right click menu for better organization:
In addition, we make Google Scholar and Short Science links configurable in the Preferences tab, under a new section named "Search Engine URL Templates". One of the comments mentioned, in the issue, that "the URL should be configurable. Reason: We cannot maintain JabRef for all site URLs; and the list of sites might be opinionated." This allows users to customize their URL templates, such as adding additional query parameters like
authoror strings.The following shows the link the user is directed to after clicking "Search Google Scholar":
Bullet Pointed List of Changes:
Collaborators
@lydia-yan @yoasaaa @brandon-lau0 @FlyJoanne
Mandatory checks
CHANGELOG.mdin a way that is understandable for the average user (if change is visible to the user)