-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
Update gradle (JabRef's patched version) and java-module-plugin #14124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This reverts commit 1fc12a7.
Do we need to investigate the environment? Here on Windows 10 and Windows 11, it worked. Does JabRef still break on your main branch? |
|
When executing I get this on I commented at gradlex-org/java-module-packaging#69 (comment) |
|
So do we need this or not? |
|
I close this for now until someone else reports about the issue |
|
I needed the patch on my machine today as follow-up to #14305. |
|
What about the other changes beside the properties file? |
These are IMHO generated with the wrapper script. I think, they can also be merged in. |
|
I upated gradle to a version of today. |
|
The issue outlined at gradlex-org/java-module-packaging#69 happens again. |
|
Ref #13324 |
…m/JabRef/jabref into revert-14033-gradlew-update-9.1.0
|
you should update the wrapper jar as well, ./gradlew wrapper |
This command does following - which is not intended --- a/gradle/wrapper/gradle-wrapper.properties
+++ b/gradle/wrapper/gradle-wrapper.properties
@@ -1,7 +1,7 @@
distributionBase=GRADLE_USER_HOME
distributionPath=wrapper/dists
-distributionUrl=https://files.jabref.org/gradle-9.3.0-jabref-2-bin.zip
+distributionUrl=https\://services.gradle.org/distributions-snapshots/gradle-9.3.0-20251116230000+0000-bin.zip
networkTimeout=10000
-validateDistributionUrl=false
+validateDistributionUrl=true
zipStoreBase=GRADLE_USER_HOME
zipStorePath=wrapper/dists |
|
I had Cloudflare issues as well today |
|
The build of this PR is available at https://builds.jabref.org/pull/14124/merge. |
…ef#14124) * Revert "Update Gradle Wrapper from 9.3.0-jabref-1 to 9.1.0 (JabRef#14033)" This reverts commit 1fc12a7. * Revert changes of gradlew and gradlew.bat * Update gradle * Add java-module-packaging patch * Fix tabs vs. spaces * WIP: Include plugin from source * Remove second includeBuild * Commit sub project * Use released version of java-module-packaging --------- Co-authored-by: Oliver Kopp <kopp.dev@gmail.com>



Reverts #14033
Did not work on my machine
Update to jabref-2
Closes https://github.com/JabRef/jabref-issue-melting-pot/issues/1114