Skip to content

Conversation

@calixtus
Copy link
Member

@calixtus calixtus commented Oct 20, 2025

Reverts #14033

Did not work on my machine

Update to jabref-2

Closes https://github.com/JabRef/jabref-issue-melting-pot/issues/1114

@calixtus calixtus requested a review from koppor October 20, 2025 20:33
@koppor
Copy link
Member

koppor commented Oct 25, 2025

Did not work on my machine

Do we need to investigate the environment? Here on Windows 10 and Windows 11, it worked.

Does JabRef still break on your main branch?

@koppor
Copy link
Member

koppor commented Oct 26, 2025

When executing ./gradlew :jabgui:jpackage, I get

> Process 'command 'C:\Users\olive\.gradle\jdks\amazon_com_inc_-24-amd64-windows.2\bin\jpackage.exe'' could not be started because the command line exceed operating system limits.

I get this on main as of today - AND with this branch.

I commented at gradlex-org/java-module-packaging#69 (comment)

@Siedlerchr
Copy link
Member

So do we need this or not?

@koppor
Copy link
Member

koppor commented Oct 30, 2025

So do we need this or not?

I don't think so, because for me, it doesn't work for both gradle variants.

@calixtus Do you have the same error as me?


Refs #14198 - I don't think, the error vanishes, but who knows...

@Siedlerchr
Copy link
Member

I close this for now until someone else reports about the issue

@koppor
Copy link
Member

koppor commented Nov 17, 2025

I needed the patch on my machine today as follow-up to #14305.

@koppor koppor reopened this Nov 17, 2025
@koppor koppor marked this pull request as ready for review November 17, 2025 12:39
@calixtus
Copy link
Member Author

What about the other changes beside the properties file?

@koppor
Copy link
Member

koppor commented Nov 17, 2025

What about the other changes beside the properties file?

These are IMHO generated with the wrapper script. I think, they can also be merged in.

@koppor koppor enabled auto-merge November 17, 2025 12:45
koppor
koppor previously approved these changes Nov 17, 2025
@koppor
Copy link
Member

koppor commented Nov 17, 2025

I upated gradle to a version of today.

@koppor
Copy link
Member

koppor commented Nov 17, 2025

The issue outlined at gradlex-org/java-module-packaging#69 happens again.

@koppor koppor changed the title Revert "Update Gradle Wrapper from 9.3.0-jabref-1 to 9.1.0" Update Gradle Wrapper to 9.3.0-jabref-2 Nov 17, 2025
@koppor koppor added the status: depends-on-external A bug or issue that depends on an update of an external library label Nov 17, 2025
@koppor
Copy link
Member

koppor commented Nov 18, 2025

Ref #13324

@koppor
Copy link
Member

koppor commented Nov 18, 2025

New submodule not checked out

grafik

@Siedlerchr
Copy link
Member

you should update the wrapper jar as well, ./gradlew wrapper

@koppor
Copy link
Member

koppor commented Nov 18, 2025

you should update the wrapper jar as well, ./gradlew wrapper

This command does following - which is not intended

--- a/gradle/wrapper/gradle-wrapper.properties
+++ b/gradle/wrapper/gradle-wrapper.properties
@@ -1,7 +1,7 @@
 distributionBase=GRADLE_USER_HOME
 distributionPath=wrapper/dists
-distributionUrl=https://files.jabref.org/gradle-9.3.0-jabref-2-bin.zip
+distributionUrl=https\://services.gradle.org/distributions-snapshots/gradle-9.3.0-20251116230000+0000-bin.zip
 networkTimeout=10000
-validateDistributionUrl=false
+validateDistributionUrl=true
 zipStoreBase=GRADLE_USER_HOME
 zipStorePath=wrapper/dists

@koppor koppor changed the title Update Gradle Wrapper to 9.3.0-jabref-2 Update gradle and java-module-plugin to JabRef's patched version Nov 18, 2025
@koppor koppor changed the title Update gradle and java-module-plugin to JabRef's patched version Update gradle and java-module-plugin to JabRef's patched versions Nov 18, 2025
@koppor koppor added dev: binaries Binary builds should be uploaded to builds.jabref.org and removed status: depends-on-external A bug or issue that depends on an update of an external library labels Nov 18, 2025
@koppor
Copy link
Member

koppor commented Nov 18, 2025

CloudFlare has issues today - therefore, we see things such as

            > Could not GET 'https://jitpack.io/com/github/sialcasa/mvvmFX/mvvmfx-validation/f195849ca9/mvvmfx-validation-f195849ca9.jar'. Received status code 500 from server: Internal Server Error
Image

@koppor
Copy link
Member

koppor commented Nov 18, 2025

JitPack has issues:

grafik

@Siedlerchr
Copy link
Member

I had Cloudflare issues as well today

@koppor koppor changed the title Update gradle and java-module-plugin to JabRef's patched versions Update gradle (JabRef's patched version) and java-module-plugin Nov 18, 2025
@koppor koppor added the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Nov 18, 2025
@github-actions
Copy link
Contributor

The build of this PR is available at https://builds.jabref.org/pull/14124/merge.

@koppor koppor added this pull request to the merge queue Nov 18, 2025
Merged via the queue into main with commit d8e5a18 Nov 18, 2025
117 of 120 checks passed
@koppor koppor deleted the revert-14033-gradlew-update-9.1.0 branch November 18, 2025 18:43
merlinymy pushed a commit to merlinymy/jabref that referenced this pull request Nov 19, 2025
…ef#14124)

* Revert "Update Gradle Wrapper from 9.3.0-jabref-1 to 9.1.0 (JabRef#14033)"

This reverts commit 1fc12a7.

* Revert changes of gradlew and gradlew.bat

* Update gradle

* Add java-module-packaging patch

* Fix tabs vs. spaces

* WIP: Include plugin from source

* Remove second includeBuild

* Commit sub project

* Use released version of java-module-packaging

---------

Co-authored-by: Oliver Kopp <kopp.dev@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dev: binaries Binary builds should be uploaded to builds.jabref.org status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants