-
Notifications
You must be signed in to change notification settings - Fork 30
Feature/device selectors #274
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/device selectors #274
Conversation
@@ -20,11 +20,41 @@ | |||
""" Implements SyclDevice Cython extension type. | |||
""" | |||
|
|||
from ._backend cimport * | |||
from ._backend cimport ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So much better :)
Looking good. I still would like to build it locally, so please wait some before merging. |
c41c5c1
to
7a2070f
Compare
Sure, I will also like to add the support for filter selector. I tried the following code. It works, but breaks the
|
ab2c12f
to
4b491e6
Compare
@oleksandr-pavlyk this one is good to go. The CI chokes up due to |
88abbba
to
30e3307
Compare
@oleksandr-pavlyk We actually do need the |
@oleksandr-pavlyk are we good to go with this? |
- Expose wrapper functions for device_selector classes in C API. - Add the C APi functions and types to _backend.pxd.
- The get_info function for a device can throw. We need to handle the possibility of a runtime_error. - Convert the Python tests for the SyclDevice class to pytest. - Add the is_* device member function to Python API.
…d depending on envars.
a898b0b
to
28022af
Compare
merging as @oleksandr-pavlyk gave his blessings :) |
This PR is extracted out of #271 and only adds the device selector classes to C API and Python API.
SyclDevice
can now be created out of SYCL's standard device selector classes.SyclDevice
can also be constructed using a filter selector string.