Skip to content

Commit a898b0b

Browse files
author
Diptorup Deb
committed
Do not use host or 0 for invalid filter test cases. These can be valid depending on envars.
1 parent 530c6ea commit a898b0b

File tree

2 files changed

+3
-4
lines changed

2 files changed

+3
-4
lines changed

dpctl-capi/tests/test_sycl_device_selector_interface.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -200,4 +200,4 @@ INSTANTIATE_TEST_SUITE_P(FilterSelectorCreation,
200200
INSTANTIATE_TEST_SUITE_P(
201201
NegativeFilterSelectorCreation,
202202
TestUnsupportedFilters,
203-
::testing::Values("host", "0", "-1", "opencl:gpu:1", "level_zero:cpu:0"));
203+
::testing::Values("abc", "-1", "opencl:gpu:1", "level_zero:cpu:0"));

dpctl/tests/test_sycl_device.py

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -45,11 +45,10 @@
4545
]
4646

4747
list_of_invalid_filter_selectors = [
48-
"host",
49-
"0",
5048
"-1",
51-
"opencl:gpu:1",
49+
"opencl:gpu:-1",
5250
"level_zero:cpu:0",
51+
"abc",
5352
]
5453

5554
# Unit test cases that will be run for every device

0 commit comments

Comments
 (0)