Skip to content

Support filter selector #271

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 54 commits into from
Closed

Support filter selector #271

wants to merge 54 commits into from

Conversation

diptorupd
Copy link
Contributor

No description provided.

@diptorupd diptorupd marked this pull request as draft February 5, 2021 01:59
@diptorupd diptorupd force-pushed the support_filter_selector branch 3 times, most recently from 2959bc5 to c9c7b9b Compare February 11, 2021 00:00
@diptorupd diptorupd mentioned this pull request Feb 15, 2021
Merged
@diptorupd diptorupd force-pushed the support_filter_selector branch 3 times, most recently from 98fd72d to 59cd3bd Compare February 17, 2021 16:48
Diptorup Deb added 22 commits February 19, 2021 12:46
Minor CMake modifications to compile all files.
312a340
Device selector support
d611864 
    - Expose wrapper functions for device_selector classes in C API.
    - Add the C APi functions and types to _backend.pxd.
Expose SYCL's device selector classes to Python API.
c5c1f37
Add declarations to pxd file.
e4e3ac0
Enables creation of a SyclDevice from a filter string
6b972b9
Handle exceptions in C API and Python test cases.
c34c349 
    - The get_info function for a device can throw. We need to
      handle the possibility of a runtime_error.
    - Convert the Python tests for the SyclDevice class to pytest.
    - Add the is_* device member function to Python API.
Add docstrings.
583b821
Change the way tests are recorded by pytest.
2f67b7e
Black formatting.
1bcdda4
Skip instead of fail when device not found.
87d6d5b
Fixes to ensure we do not expose _SyclDevice to users.
d6626e6
Fix compilation error.
c08c007
Fix compilation error properly this time.
adf2be6
Do not use host or 0 for invalid filter test cases. These can be vali…
72cb92c 
…d depending on envars.
Update changelog.
28022af
WIP macros to generate vector types and functions.
f799f55
Introduces a device manager module.
62ef330
Fix few doc strings and rename a function.
7a01dc9
Clang-format changes...
e8a5068
Merge branch 'upstream_master' into feature/device_manager
6e10e00
Remove duplicate declaration.
1d7649c
Enables creation of a SyclDevice from a filter string
2360ec3
@diptorupd diptorupd force-pushed the support_filter_selector branch from 59cd3bd to 80d039e Compare February 20, 2021 17:59
@oleksandr-pavlyk
Copy link
Contributor

@diptorupd Is this PR still relevant?

@diptorupd
Copy link
Contributor Author

@diptorupd Is this PR still relevant?

It still has C API changes to expose context constructors and some changes to the platform_interface. I will extract those out and open separate PRs and close this one.

@oleksandr-pavlyk
Copy link
Contributor

@diptorupd Is this PR still relevant?

It still has C API changes to expose context constructors and some changes to the platform_interface. I will extract those out and open separate PRs and close this one.

This would be helpful. I thought of working on dpctl.SyclContext next. I did not realize the C-API is not there yet.

@oleksandr-pavlyk
Copy link
Contributor

I think this PR is now ready to retire :)

@diptorupd
Copy link
Contributor Author

The last bit of CMake changes are now in #319. Closing (sigh!). What an epic PR that helped launch a "thousand" other PRs, but alas itself never reached master.

@diptorupd diptorupd closed this May 6, 2021
@diptorupd diptorupd deleted the support_filter_selector branch May 23, 2021 04:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ndgrigorian ndgrigorian Awaiting requested review from ndgrigorian ndgrigorian will be requested when the pull request is marked ready for review ndgrigorian is a code owner

@antonwolfy antonwolfy Awaiting requested review from antonwolfy antonwolfy will be requested when the pull request is marked ready for review antonwolfy is a code owner

@vlad-perevezentsev vlad-perevezentsev Awaiting requested review from vlad-perevezentsev vlad-perevezentsev will be requested when the pull request is marked ready for review vlad-perevezentsev is a code owner

@vtavana vtavana Awaiting requested review from vtavana vtavana will be requested when the pull request is marked ready for review vtavana is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@diptorupd @oleksandr-pavlyk