-
Notifications
You must be signed in to change notification settings - Fork 30
C API build script improvements to build dpctl with a custom DPC++ and other changes #319
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
36eaaa6
to
4e40659
Compare
What about Windows? Should we have |
I added the script for windows. For some reason, I can build but not run the gtests on Windows. The |
b64da3b
to
fbffc14
Compare
@PokhodenkoSA how can the C API gtests be run on Windows? I am using the |
On Linux too. I did not find gtest run on Linux CI. |
@diptorupd what is the status of the task? |
056086c
to
ab80882
Compare
@oleksandr-pavlyk I cleaned this PR and removed most of the changes to the Python package build scripts (there are still few cosmetic ones). The changes here are only related to our CMake scripts to build |
The cmake module finder for LLVMCov seems to have a problem:
and the same time:
|
Linux CI failed with
|
The CMake runs fine now with nightly build of Using CMake 3.20 I run into trouble with finding Building of The linking phase fails with message:
but it may have to do with my setup more than changes in this PR. |
@PokhodenkoSA Should these be libraries be expected in CI ? Should we be setting |
fbfb3ae
to
2df9735
Compare
I do not think that is the problem here. |
797a6e7
to
3cae7db
Compare
b690f45
to
80021ff
Compare
I added the changes we discussed on Friday. The new Few more changes:
I will fix the Windows build with Level zero support and add an action to test the build with the public dpcpp binaries. |
@oleksandr-pavlyk Now this needs your expertise :) The issue with the Linux CI is that post adding soname to |
3a11295
to
83d57e4
Compare
@oleksandr-pavlyk Tremendous!! |
83d57e4
to
999e4f0
Compare
999e4f0
to
5ed4140
Compare
…ompiler. - FindDPCPP.cmake is now renamed to FindIntelSycl.cmake. - llvm-cov and llvm-profdata now have their own cmake modules and the minimum version required is 11.0.0 for these tools. - CMAKE_C_COMPILER and CMAKE_CXX_COMPILER are now set by the FindIntelSycl.cmake module and do not need to be set manually. - A new CMAKE flag DPCTL_CUSTOM_DPCPP_INSTALL_DIR is now available that makes it possible to build the DPCTLSyclInterface with a custom dpcpp compiler. - Formatting changes to CMakeLists.txt files. - A new helper script to build the DPCTLSyclInterface library using a custom dpcpp. - All version checking for CMake modules requirements uses LESS_EQUAL instead of EQUAL. - Replaced FindLevelZero cmake module with GetLevelZeroHeaders module which checks out Level zero repo to satisfy dependency of DPCTL on Level-zero headers when configured - Added GetProjectVersion cmake module to get version and semantic version information for Git repos.
Now that Level zero is being checkout out, the location of the .h file has changed and is controlled via include directory path.
5ed4140
to
b7bd9b9
Compare
Closes #259
Closes #340
and the minimum version required is 11.0.0 for these tools.
that makes it possible to build the DPCTLSyclInterface with a
custom dpcpp compiler.
dpctl-capi/helper
are now included in coverage reports.