-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Init without working range size #686
Init without working range size #686
Conversation
@ocrickard, @rnystrom thought you might be interested in looking at this as well. |
Source/IGListAdapter.h
Outdated
@@ -103,6 +103,17 @@ IGLK_SUBCLASSING_RESTRICTED | |||
workingRangeSize:(NSInteger)workingRangeSize NS_DESIGNATED_INITIALIZER; | |||
|
|||
/** | |||
Initializes a new `IGListAdapter` object. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's add that this uses workingRangeSize 0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also changed the opt-out to prefer the new init over providing 0
as a value.
@BasThomas updated the pull request - view changes |
Source/IGListAdapter.h
Outdated
@@ -96,13 +96,26 @@ IGLK_SUBCLASSING_RESTRICTED | |||
the previous and succeeding 2 objects will be notified that they are within the working range. As you scroll the list | |||
the range is updated as objects enter and exit the working range. | |||
|
|||
To opt out of using the working range, you can provide a value of `0`. | |||
To opt out of using the working range, use `initWithUpdater:viewController` instead. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suuuuuper nit: can this be
To opt out of using the working range, use
initWithUpdater:viewController:
or provide a working range of0
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Of course!
@BasThomas updated the pull request - view changes |
@BasThomas updated the pull request - view changes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉
@jessesquires has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
Changes in this pull request
Issue fixed: #414
Checklist
CHANGELOG.md
for any breaking changes, enhancements, or bug fixes.What should we do with testing? I changed all the occurrences of the old initializer with the new one, so I think this is good to go?