Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Init without working range size #686

Closed
wants to merge 7 commits into from
Closed

Init without working range size #686

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
ff9601e
Merge remote-tracking branch 'Instagram/master'
BasThomas Apr 21, 2017
f97bea4
Add initializer defaulting to a workingRangeSize of 0
BasThomas Apr 21, 2017
8e32f59
Use new init in example projects
BasThomas Apr 21, 2017
3bf02bc
Add new init to Changelog
BasThomas Apr 21, 2017
3c98f65
Note that the new init defaults to a working range of 0
BasThomas Apr 21, 2017
413a7c9
Update IGListAdapter.h
BasThomas Apr 21, 2017
4cdf1b8
Update IGListAdapter.h
jessesquires Apr 21, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion Source/IGListAdapter.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,7 @@ IGLK_SUBCLASSING_RESTRICTED
the previous and succeeding 2 objects will be notified that they are within the working range. As you scroll the list
the range is updated as objects enter and exit the working range.

To opt out of using the working range, you can provide a value of `0`.
To opt out of using the working range, use `initWithUpdater:viewController` instead.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suuuuuper nit: can this be

To opt out of using the working range, use initWithUpdater:viewController: or provide a working range of 0.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Of course!

*/
- (instancetype)initWithUpdater:(id <IGListUpdatingDelegate>)updater
viewController:(nullable UIViewController *)viewController
Expand All @@ -108,6 +108,8 @@ IGLK_SUBCLASSING_RESTRICTED
@param updater An object that manages updates to the collection view.
@param viewController The view controller that will house the adapter.

@note This defaults the working range to 0.

@return A new list adapter object.
*/
- (instancetype)initWithUpdater:(id <IGListUpdatingDelegate>)updater
Expand Down