-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove workingRangeSize from initializer #414
Comments
Which of the two options would you prefer and why? Reading this, I'd think the first option would be best. |
@BasThomas let's do the first! I agree, easier for everyone. |
@BasThomas if you want to / have time to do this within the next week or so, we can include in the 3.0 release 😄 |
So I was looking at this - do we want to deprecate and remove the option to provide a working range size completely? Or should we still provide the init for advanced usage (or the property to set after |
@BasThomas let's leave the current init as the designated initializer still, but provide an initializer that internally does Also would you mind double-checking what work IGListWorkingRangeHandler does when the size is 0? I think it basically no-ops, but we might want to wrap initializing the handler with something like: if (workingRangeSize > 0) {
_workingRangeHandler = // ...
} Might want to sync w/ @ocrickard really quick too to see if that's the best course of action. |
When we do a no-op (not initializing the |
Hmmm. We can followup w/ another issue on that. We might want to consider removing those tests and not using the working range when size = 0. |
Talked w/ @ocrickard, probably default disabled and allow setting the size (which would internally create and update the WR state) after initing the
IGListAdapter
.Incredibly useful feature, but:
UICollectionView
prefetch API worksOptions:
initWithUpdater:viewController:
andinitWithUpdater:viewController:workingRangeSize:
__attribute__ ((deprecated))
to the old init?@property NSUInteger workingRangeSize
The text was updated successfully, but these errors were encountered: