Repository navigation
Conversation
mddragnev
added
❌ status: awaiting-test
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Shift-based + events can still mutate cell selection before the new guard returns.
Review effort: Balanced
Findings: 1
Open (1)
What changed in this PR
Prevents grid navigation from dereferencing an undefined target when + or = is pressed.
Changes:
- Adds an early return when no navigation position exists.
- Adds focused-cell and cell-editor regression tests.
| File | Description |
|---|---|
grid-navigation.service.ts |
Guards missing navigation positions. |
grid-keyBoardNav.spec.ts |
Tests focused-cell key handling. |
grid-cell-editing.spec.ts |
Tests editor key handling. |
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
mddragnev
changed the title
viktorkombov
added
💥 status: in-test
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #17577 #17605
Description
Typing
+or=in a grid cell editor, or pressing them (or theCtrl++zoom shortcut) on a focused cell, threw TypeError: Cannot read properties of undefined (reading 'rowIndex'), and in the editor the character wasn't inserted. This fixes the regression by havingdispatchEventreturn early whengetNextPositiongives no target positionType of Change (check all that apply):
Component(s) / Area(s) Affected:
How Has This Been Tested?
Test Configuration:
Screenshots / Recordings
Checklist:
feature/README.MDupdates for the feature docsREADME.MDCHANGELOG.MDupdates for newly added functionalityng updatemigrations for the breaking changes (migrations guidelines)