-
Notifications
You must be signed in to change notification settings - Fork 25
Optimize queries #405
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Optimize queries #405
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
03b29cb
to
4984f68
Compare
e5cef37
to
f00246b
Compare
Blocked by Icinga/icinga2#9049 |
f00246b
to
88564b2
Compare
3a3203e
to
9cd2350
Compare
Needs just to be tested properly after these PRs are merged. |
ee5914c
to
2f80662
Compare
Since `n` is the default value for enums, asc would display ineffective downtimes first. Co-authored-by: Eric Lippmann <eric.lippmann@icinga.com>
Co-authored-by: Eric Lippmann <eric.lippmann@icinga.com>
Simultaneous sorting by `host.display_name` and `service.display_name` and vice versa prevents the use of the display_name indexes. Co-authored-by: Eric Lippmann <eric.lippmann@icinga.com>
Co-authored-by: Eric Lippmann <eric.lippmann@icinga.com>
Otherwise, MySQL won't utilize the event_time index. Co-authored-by: Eric Lippmann <eric.lippmann@icinga.com>
Otherwise, MySQL will not use indexes on the state tables when filtering / sorting the views by columns from the state tables. Co-authored-by: Eric Lippmann <eric.lippmann@icinga.com>
2f80662
to
2405936
Compare
Despite Icinga/icingadb#397 not being merged yet, this one is ready to review. |
nilmerg
reviewed
Nov 12, 2021
nilmerg
approved these changes
Nov 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #404