Skip to content

Add more MySQL indexes #397

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 12, 2021
Merged

Add more MySQL indexes #397

merged 1 commit into from
Nov 12, 2021

Conversation

yhabteab
Copy link
Member

@yhabteab yhabteab commented Oct 26, 2021 •
edited
Loading

@cla-bot cla-bot bot added the cla/signed label Oct 26, 2021
@yhabteab yhabteab force-pushed the introduce-more-indexes branch from d07de67 to b03b706 Compare November 2, 2021 16:40
@yhabteab
Copy link
Member Author

yhabteab commented Nov 2, 2021 •
edited by julianbrost
Loading

Blocked by

@yhabteab yhabteab marked this pull request as ready for review November 2, 2021 16:40
@yhabteab yhabteab mentioned this pull request Nov 4, 2021
Merged
@yhabteab yhabteab force-pushed the introduce-more-indexes branch from 8fc6aaf to fb5e074 Compare November 5, 2021 17:00
@yhabteab yhabteab mentioned this pull request Nov 5, 2021
Merged
@yhabteab
Copy link
Member Author

yhabteab commented Nov 5, 2021

Test history, downtime and service_state indices whether they really improve the performance of Icinga DB Web.

@yhabteab yhabteab force-pushed the introduce-more-indexes branch from fb5e074 to b4ad5a2 Compare November 5, 2021 17:56
@yhabteab @lippserd
MySQL: Add more indexes
611b68c 
Co-authored-by: Eric Lippmann <eric.lippmann@icinga.com>
@lippserd lippserd force-pushed the introduce-more-indexes branch from b4ad5a2 to 611b68c Compare November 12, 2021 11:57
@lippserd lippserd changed the title Add more mysql indexes Add more MySQL indexes Nov 12, 2021
@lippserd lippserd added this to the v1.0.0-rc2 milestone Nov 12, 2021
@lippserd lippserd requested a review from julianbrost November 12, 2021 14:05
@julianbrost
Copy link
Contributor

What's the expected benefit for queries? Like is it more like unbearably slow -> acceptable or acceptable -> instant? Was write performance also considered when adding these?

@N-o-X N-o-X self-requested a review November 12, 2021 16:23
@julianbrost
Copy link
Contributor

I've done my standard schema upgrade diff from RC1 and it was fine. So if someone has a look that the actual changes are fine, this could be merged.

@lippserd lippserd merged commit eb468af into master Nov 12, 2021
@lippserd lippserd deleted the introduce-more-indexes branch November 12, 2021 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@N-o-X N-o-X N-o-X approved these changes

@julianbrost julianbrost Awaiting requested review from julianbrost

Assignees
No one assigned
Labels
cla/signed
Projects
None yet
Milestone
1.0.0-rc2
Development

Successfully merging this pull request may close these issues.
4 participants
@yhabteab @julianbrost @N-o-X @lippserd