ServicegroupSummary: Don't use unions & sub-selects for ServicegroupSummary

Author: yhabteab

application/controllers/ServicegroupController.php

@@ -27,12 +27,9 @@ public function init()
         $name = $this->params->getRequired('name');
 
         $query = ServicegroupSummary::on($this->getDb());
-        $query->disableDefaultSort();
-
-        foreach ($query->getUnions() as $unionPart) {
-            $unionPart->filter(Filter::equal('servicegroup.name', $name));
-            $unionPart->disableDefaultSort();
-        }
+        $query
+            ->disableDefaultSort()
+            ->filter(Filter::equal('servicegroup.name', $name));
 
         $this->applyRestrictions($query);
 

library/Icingadb/Model/ServicegroupSummary.php

@@ -4,57 +4,58 @@
 
 namespace Icinga\Module\Icingadb\Model;
 
-use ipl\Orm\UnionModel;
+use ipl\Orm\Query;
 use ipl\Sql\Expression;
 
-class ServicegroupSummary extends UnionModel
+class ServicegroupSummary extends Servicegroup
 {
-    public function getTableName()
-    {
-        return 'servicegroup';
-    }
-
-    public function getKeyName()
-    {
-        return ['id' => 'servicegroup_id'];
-    }
-
     public function getColumns()
     {
         return [
-            'display_name'                => 'servicegroup_display_name',
-            'name'                        => 'servicegroup_name',
+            'display_name'                => 'display_name',
+            'name'                        => 'name',
             'services_critical_handled'   => new Expression(
-                'SUM(CASE WHEN service_state = 2 AND service_handled = \'y\' THEN 1 ELSE 0 END)'
+                'SUM(CASE WHEN servicegroup_service_state.soft_state = 2 
+                AND servicegroup_service_state.is_handled = \'y\' THEN 1 ELSE 0 END)'
             ),
             'services_critical_unhandled' => new Expression(
-                'SUM(CASE WHEN service_state = 2 AND service_handled = \'n\' THEN 1 ELSE 0 END)'
+                'SUM(CASE WHEN servicegroup_service_state.soft_state = 2 
+                AND servicegroup_service_state.is_handled = \'n\' THEN 1 ELSE 0 END)'
             ),
             'services_ok'                 => new Expression(
-                'SUM(CASE WHEN service_state = 0 THEN 1 ELSE 0 END)'
+                'SUM(CASE WHEN servicegroup_service_state.soft_state = 0 THEN 1 ELSE 0 END)'
             ),
             'services_pending'            => new Expression(
-                'SUM(CASE WHEN service_state = 99 THEN 1 ELSE 0 END)'
+                'SUM(CASE WHEN servicegroup_service_state.soft_state = 99 THEN 1 ELSE 0 END)'
             ),
             'services_total'              => new Expression(
-                'SUM(CASE WHEN service_id IS NOT NULL THEN 1 ELSE 0 END)'
+                'SUM(CASE WHEN servicegroup_servicegroup_member.service_id IS NOT NULL THEN 1 ELSE 0 END)'
             ),
             'services_unknown_handled'    => new Expression(
-                'SUM(CASE WHEN service_state = 3 AND service_handled = \'y\' THEN 1 ELSE 0 END)'
+                'SUM(CASE WHEN servicegroup_service_state.soft_state = 3 
+                AND servicegroup_service_state.is_handled = \'y\' THEN 1 ELSE 0 END)'
             ),
             'services_unknown_unhandled'  => new Expression(
-                'SUM(CASE WHEN service_state = 3 AND service_handled = \'n\' THEN 1 ELSE 0 END)'
+                'SUM(CASE WHEN servicegroup_service_state.soft_state = 3 
+                AND servicegroup_service_state.is_handled = \'n\' THEN 1 ELSE 0 END)'
             ),
             'services_warning_handled'    => new Expression(
-                'SUM(CASE WHEN service_state = 1 AND service_handled = \'y\' THEN 1 ELSE 0 END)'
+                'SUM(CASE WHEN servicegroup_service_state.soft_state = 1 
+                AND servicegroup_service_state.is_handled = \'y\' THEN 1 ELSE 0 END)'
             ),
             'services_warning_unhandled'  => new Expression(
-                'SUM(CASE WHEN service_state = 1 AND service_handled = \'n\' THEN 1 ELSE 0 END)'
+                'SUM(CASE WHEN servicegroup_service_state.soft_state = 1 
+                AND servicegroup_service_state.is_handled = \'n\' THEN 1 ELSE 0 END)'
             ),
-            'services_severity'           => new Expression('MAX(service_severity)')
+            'services_severity'           => new Expression('MAX(servicegroup_service_state.severity)')
         ];
     }
 
+    public function getMetaData()
+    {
+        return [];
+    }
+
     public function getAggregateColumns()
     {
         return true;
@@ -65,45 +66,15 @@ public function getSearchColumns()
         return ['display_name'];
     }
 
-    public function getDefaultSort()
-    {
-        return 'display_name';
-    }
-
-    public function getUnions()
+    public function createDefaultUtilize(Query $query)
     {
-        $unions = [
-            [
-                Servicegroup::class,
-                [],
-                [
-                    'servicegroup_id'           => 'servicegroup.id',
-                    'servicegroup_name'         => 'servicegroup.name',
-                    'servicegroup_display_name' => 'servicegroup.display_name',
-                    'service_id'                => new Expression('NULL'),
-                    'service_state'             => new Expression('NULL'),
-                    'service_handled'           => new Expression('NULL'),
-                    'service_severity'          => new Expression('0')
-                ]
-            ],
-            [
-                Service::class,
-                [
-                    'servicegroup',
-                    'state'
-                ],
-                [
-                    'servicegroup_id'           => 'servicegroup.id',
-                    'servicegroup_name'         => new Expression('NULL'),
-                    'servicegroup_display_name' => new Expression('NULL'),
-                    'service_id'                => 'service.id',
-                    'service_state'             => 'state.soft_state',
-                    'service_handled'           => 'state.is_handled',
-                    'service_severity'          => 'state.severity'
-                ]
-            ]
-        ];
+        $query->utilize([
+            'service',
+            'service.state'
+        ]);
 
-        return $unions;
+        // We need to select all servicegroups regardless of whether they have services or not
+        $query->getUtilize()['servicegroup.service']->setJoinType('LEFT');
+        $query->getUtilize()['servicegroup.service.state']->setJoinType('LEFT');
     }
 }