-
Notifications
You must be signed in to change notification settings - Fork 669
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added support for reserved ip patch resource #5603
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ujjwal-ibm
force-pushed
the
reserved-ip-patch
branch
from
September 4, 2024 07:03
0c5efdf
to
5544d43
Compare
sreekarbvibm
approved these changes
Sep 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
hkantare
approved these changes
Sep 13, 2024
hkantare
pushed a commit
that referenced
this pull request
Sep 13, 2024
* Added support for ibm_is_subnet_reserved_ip_patch resource * updated the name to optional * Update is_subnet_reserved_ip_patch.html.markdown
srikant-sahu
pushed a commit
to srikant-sahu/terraform-provider-ibm
that referenced
this pull request
Sep 24, 2024
* Added support for ibm_is_subnet_reserved_ip_patch resource * updated the name to optional * Update is_subnet_reserved_ip_patch.html.markdown
Ramya-c4
pushed a commit
to Ramya-c4/terraform-provider-ibm
that referenced
this pull request
Sep 26, 2024
* Added support for ibm_is_subnet_reserved_ip_patch resource * updated the name to optional * Update is_subnet_reserved_ip_patch.html.markdown
Ramya-c4
pushed a commit
to Ramya-c4/terraform-provider-ibm
that referenced
this pull request
Sep 27, 2024
…s_tag. Fixed 5566 too. (IBM-Cloud#5567) * Deprecated ibm_resource_access_tag in favor of ibm_iam_access_tag * changes * Fix * Changed resource to speed up tests * fix * PR changes * PR changes SM New error formatting + crypto_key label name changes (IBM-Cloud#5562) * SC addition * SC addition * SC addition * update function updated * SC unit tests added * SC unit tests added * d * tests fixes * tests fixes * update sdk * .secrets.baseline update * .secrets.baseline update * .secrets.baseline update * Update sm_service_credentials_secret_metadata.html.markdown * bugs fixes * bugs fixes * bugs fixes * docs bugs fixes * preferred_chain added for public cert lets encrypt configuration * support for creating secret version for username password & version_custom_metadata for all * support for creating secret version for username password & version_custom_metadata for all * support for creating secret version for username password & version_custom_metadata for all * support for creating secret version for username password & version_custom_metadata for all * support for creating secret version for username password & version_custom_metadata for all * support for creating secret version for username password & version_custom_metadata for all * preferred chain docs update * support for creating secret version for username password & version_custom_metadata for all * support for creating secret version for username password & version_custom_metadata for all * support for creating secret version for username password & version_custom_metadata for all * fix public cert bug * update docs * reordering bug in alt_names * name regex fix in docs * imported cert bug fix * crypto_key addition * crypto_key addition * crypto_key addition * crypto_key addition * rejections fixes * rejections fixes * rejections fixes * rejections fixes * rejections fixes * test label name changed * test label name changed * error formating update * go sdk version update --------- Co-authored-by: Yonathan-Yellin <yonathan.yellin@ibm.com> Co-authored-by: Avi Ribchinsky <avir@il.ibm.com> Co-authored-by: Tatyana <tatyanab@il.ibm.com> Co-authored-by: Idan Adar <iadar@il.ibm.com> Deprecating alias and bindings APIs and schema items (IBM-Cloud#5612) * Deprecating alias and bindings APIs and schema items Signed-off-by: arshabbir <arshabbir@gmail.com> * Deprecating alias and bindings APIs and schema items --------- Signed-off-by: arshabbir <arshabbir@gmail.com> Add region parameter to logs-routing resources and data sources (IBM-Cloud#5634) * Added region parameter to logs-routing resources and data sources Signed-off-by: Ian Reyes <ianre@ibm.com> * Fixed examples for logs-routing resources --------- Signed-off-by: Ian Reyes <ianre@ibm.com> Co-authored-by: Ian Reyes <ianre@ibm.com> update(cloud-databases): Make Service Endpoints Required and send warning when public endpoints are in use (IBM-Cloud#5402) Added support for reserved ip patch resource (IBM-Cloud#5603) * Added support for ibm_is_subnet_reserved_ip_patch resource * updated the name to optional * Update is_subnet_reserved_ip_patch.html.markdown fix(is_share): added empty check and moved source_share_crn outside (IBM-Cloud#5632) discourage use of ibm_container_bind_service (IBM-Cloud#5588) * discourage use of ibm_container_bind_service Signed-off-by: Bence Vidosits <bence.vidosits1@ibm.com> * fix link --------- Signed-off-by: Bence Vidosits <bence.vidosits1@ibm.com> Co-authored-by: Bence Vidosits <bence.vidosits1@ibm.com> updated resources, data source and documentation for Slack Direct destination support Add test bucket endpoints (IBM-Cloud#5636) * add changes for test bucket endpoints * update code --------- Co-authored-by: Deeksha Sharma <deekshasharma@Deekshas-MacBook-Pro.local> Add support for Code Engine functions (IBM-Cloud#5596) * Add support for Code Engine functions * update .secrets.baseline * remove unnecessary check Fix the 5635 - The ibm_resource_tag now checks the response in the api tags calls (IBM-Cloud#5641) * Deprecated ibm_resource_access_tag in favor of ibm_iam_access_tag * changes * Fix * Changed resource to speed up tests * fix * PR changes * PR changes --------- ---------
Ramya-c4
added a commit
to Ramya-c4/terraform-provider-ibm
that referenced
this pull request
Sep 27, 2024
Deprecated ibm_resource_access_tag and replaced it with ibm_iam_access_tag. Fixed 5566 too. (IBM-Cloud#5567) * Deprecated ibm_resource_access_tag in favor of ibm_iam_access_tag * changes * Fix * Changed resource to speed up tests * fix * PR changes * PR changes SM New error formatting + crypto_key label name changes (IBM-Cloud#5562) * SC addition * SC addition * SC addition * update function updated * SC unit tests added * SC unit tests added * d * tests fixes * tests fixes * update sdk * .secrets.baseline update * .secrets.baseline update * .secrets.baseline update * Update sm_service_credentials_secret_metadata.html.markdown * bugs fixes * bugs fixes * bugs fixes * docs bugs fixes * preferred_chain added for public cert lets encrypt configuration * support for creating secret version for username password & version_custom_metadata for all * support for creating secret version for username password & version_custom_metadata for all * support for creating secret version for username password & version_custom_metadata for all * support for creating secret version for username password & version_custom_metadata for all * support for creating secret version for username password & version_custom_metadata for all * support for creating secret version for username password & version_custom_metadata for all * preferred chain docs update * support for creating secret version for username password & version_custom_metadata for all * support for creating secret version for username password & version_custom_metadata for all * support for creating secret version for username password & version_custom_metadata for all * fix public cert bug * update docs * reordering bug in alt_names * name regex fix in docs * imported cert bug fix * crypto_key addition * crypto_key addition * crypto_key addition * crypto_key addition * rejections fixes * rejections fixes * rejections fixes * rejections fixes * rejections fixes * test label name changed * test label name changed * error formating update * go sdk version update --------- Co-authored-by: Yonathan-Yellin <yonathan.yellin@ibm.com> Co-authored-by: Avi Ribchinsky <avir@il.ibm.com> Co-authored-by: Tatyana <tatyanab@il.ibm.com> Co-authored-by: Idan Adar <iadar@il.ibm.com> Deprecating alias and bindings APIs and schema items (IBM-Cloud#5612) * Deprecating alias and bindings APIs and schema items Signed-off-by: arshabbir <arshabbir@gmail.com> * Deprecating alias and bindings APIs and schema items --------- Signed-off-by: arshabbir <arshabbir@gmail.com> Add region parameter to logs-routing resources and data sources (IBM-Cloud#5634) * Added region parameter to logs-routing resources and data sources Signed-off-by: Ian Reyes <ianre@ibm.com> * Fixed examples for logs-routing resources --------- Signed-off-by: Ian Reyes <ianre@ibm.com> Co-authored-by: Ian Reyes <ianre@ibm.com> update(cloud-databases): Make Service Endpoints Required and send warning when public endpoints are in use (IBM-Cloud#5402) Added support for reserved ip patch resource (IBM-Cloud#5603) * Added support for ibm_is_subnet_reserved_ip_patch resource * updated the name to optional * Update is_subnet_reserved_ip_patch.html.markdown fix(is_share): added empty check and moved source_share_crn outside (IBM-Cloud#5632) discourage use of ibm_container_bind_service (IBM-Cloud#5588) * discourage use of ibm_container_bind_service Signed-off-by: Bence Vidosits <bence.vidosits1@ibm.com> * fix link --------- Signed-off-by: Bence Vidosits <bence.vidosits1@ibm.com> Co-authored-by: Bence Vidosits <bence.vidosits1@ibm.com> updated resources, data source and documentation for Slack Direct destination support Add test bucket endpoints (IBM-Cloud#5636) * add changes for test bucket endpoints * update code --------- Co-authored-by: Deeksha Sharma <deekshasharma@Deekshas-MacBook-Pro.local> Add support for Code Engine functions (IBM-Cloud#5596) * Add support for Code Engine functions * update .secrets.baseline * remove unnecessary check Fix the 5635 - The ibm_resource_tag now checks the response in the api tags calls (IBM-Cloud#5641) * Deprecated ibm_resource_access_tag in favor of ibm_iam_access_tag * changes * Fix * Changed resource to speed up tests * fix * PR changes * PR changes --------- --------- Deprecating alias and bindings APIs and schema items (IBM-Cloud#5612) --------- IAM Policy Assignment: S2S Policy Assignments ET and AG (IBM-Cloud#5624) * IAM Policy Assignment: S2S Policy Assignments ET and AG Signed-off-by: Alluri-Varma <alluri.varma@ibm.com> * resolving CVE's for EPAP * IAM Policy Assignment: S2S Policy Assignments ET and AG * IAM Policy Assignment: S2S Policy Assignments ET and AG * IAM Policy Assignment: S2S Policy Assignments ET and AG * IAM Policy Assignment: S2S Policy Assignments ET and AG * IAM Policy Assignment: S2S Policy Assignments ET and AG * IAM Policy Assignment: S2S Policy Assignments ET and AG * IAM Policy Assignment: S2S Policy Assignments ET and AG --------- Signed-off-by: Alluri-Varma <alluri.varma@ibm.com> Co-authored-by: Alluri-Varma <alluri.varma@ibm.com> migrattion of vpc-go-sdk to 0.58.0 (IBM-Cloud#5652) * migration of vpc-go-sdk to 0.58.0 * make fmt changes
Ramya-c4
added a commit
to Ramya-c4/terraform-provider-ibm
that referenced
this pull request
Sep 27, 2024
Deprecated ibm_resource_access_tag and replaced it with ibm_iam_access_tag. Fixed 5566 too. (IBM-Cloud#5567) * Deprecated ibm_resource_access_tag in favor of ibm_iam_access_tag * changes * Fix * Changed resource to speed up tests * fix * PR changes * PR changes SM New error formatting + crypto_key label name changes (IBM-Cloud#5562) * SC addition * SC addition * SC addition * update function updated * SC unit tests added * SC unit tests added * d * tests fixes * tests fixes * update sdk * .secrets.baseline update * .secrets.baseline update * .secrets.baseline update * Update sm_service_credentials_secret_metadata.html.markdown * bugs fixes * bugs fixes * bugs fixes * docs bugs fixes * preferred_chain added for public cert lets encrypt configuration * support for creating secret version for username password & version_custom_metadata for all * support for creating secret version for username password & version_custom_metadata for all * support for creating secret version for username password & version_custom_metadata for all * support for creating secret version for username password & version_custom_metadata for all * support for creating secret version for username password & version_custom_metadata for all * support for creating secret version for username password & version_custom_metadata for all * preferred chain docs update * support for creating secret version for username password & version_custom_metadata for all * support for creating secret version for username password & version_custom_metadata for all * support for creating secret version for username password & version_custom_metadata for all * fix public cert bug * update docs * reordering bug in alt_names * name regex fix in docs * imported cert bug fix * crypto_key addition * crypto_key addition * crypto_key addition * crypto_key addition * rejections fixes * rejections fixes * rejections fixes * rejections fixes * rejections fixes * test label name changed * test label name changed * error formating update * go sdk version update --------- Co-authored-by: Yonathan-Yellin <yonathan.yellin@ibm.com> Co-authored-by: Avi Ribchinsky <avir@il.ibm.com> Co-authored-by: Tatyana <tatyanab@il.ibm.com> Co-authored-by: Idan Adar <iadar@il.ibm.com> Deprecating alias and bindings APIs and schema items (IBM-Cloud#5612) * Deprecating alias and bindings APIs and schema items Signed-off-by: arshabbir <arshabbir@gmail.com> * Deprecating alias and bindings APIs and schema items --------- Signed-off-by: arshabbir <arshabbir@gmail.com> Add region parameter to logs-routing resources and data sources (IBM-Cloud#5634) * Added region parameter to logs-routing resources and data sources Signed-off-by: Ian Reyes <ianre@ibm.com> * Fixed examples for logs-routing resources --------- Signed-off-by: Ian Reyes <ianre@ibm.com> Co-authored-by: Ian Reyes <ianre@ibm.com> update(cloud-databases): Make Service Endpoints Required and send warning when public endpoints are in use (IBM-Cloud#5402) Added support for reserved ip patch resource (IBM-Cloud#5603) * Added support for ibm_is_subnet_reserved_ip_patch resource * updated the name to optional * Update is_subnet_reserved_ip_patch.html.markdown fix(is_share): added empty check and moved source_share_crn outside (IBM-Cloud#5632) discourage use of ibm_container_bind_service (IBM-Cloud#5588) * discourage use of ibm_container_bind_service Signed-off-by: Bence Vidosits <bence.vidosits1@ibm.com> * fix link --------- Signed-off-by: Bence Vidosits <bence.vidosits1@ibm.com> Co-authored-by: Bence Vidosits <bence.vidosits1@ibm.com> updated resources, data source and documentation for Slack Direct destination support Add test bucket endpoints (IBM-Cloud#5636) * add changes for test bucket endpoints * update code --------- Co-authored-by: Deeksha Sharma <deekshasharma@Deekshas-MacBook-Pro.local> Add support for Code Engine functions (IBM-Cloud#5596) * Add support for Code Engine functions * update .secrets.baseline * remove unnecessary check Fix the 5635 - The ibm_resource_tag now checks the response in the api tags calls (IBM-Cloud#5641) * Deprecated ibm_resource_access_tag in favor of ibm_iam_access_tag * changes * Fix * Changed resource to speed up tests * fix * PR changes * PR changes --------- --------- Deprecating alias and bindings APIs and schema items (IBM-Cloud#5612) --------- IAM Policy Assignment: S2S Policy Assignments ET and AG (IBM-Cloud#5624) * IAM Policy Assignment: S2S Policy Assignments ET and AG Signed-off-by: Alluri-Varma <alluri.varma@ibm.com> * resolving CVE's for EPAP * IAM Policy Assignment: S2S Policy Assignments ET and AG * IAM Policy Assignment: S2S Policy Assignments ET and AG * IAM Policy Assignment: S2S Policy Assignments ET and AG * IAM Policy Assignment: S2S Policy Assignments ET and AG * IAM Policy Assignment: S2S Policy Assignments ET and AG * IAM Policy Assignment: S2S Policy Assignments ET and AG * IAM Policy Assignment: S2S Policy Assignments ET and AG --------- Signed-off-by: Alluri-Varma <alluri.varma@ibm.com> Co-authored-by: Alluri-Varma <alluri.varma@ibm.com> migrattion of vpc-go-sdk to 0.58.0 (IBM-Cloud#5652) * migration of vpc-go-sdk to 0.58.0 * make fmt changes IAM Policy Assignment: S2S Policy Assignments ET and AG (IBM-Cloud#5624) * IAM Policy Assignment: S2S Policy Assignments ET and AG Signed-off-by: Alluri-Varma <alluri.varma@ibm.com> * resolving CVE's for EPAP * IAM Policy Assignment: S2S Policy Assignments ET and AG * IAM Policy Assignment: S2S Policy Assignments ET and AG * IAM Policy Assignment: S2S Policy Assignments ET and AG * IAM Policy Assignment: S2S Policy Assignments ET and AG * IAM Policy Assignment: S2S Policy Assignments ET and AG * IAM Policy Assignment: S2S Policy Assignments ET and AG * IAM Policy Assignment: S2S Policy Assignments ET and AG --------- Signed-off-by: Alluri-Varma <alluri.varma@ibm.com> Co-authored-by: Alluri-Varma <alluri.varma@ibm.com> migrattion of vpc-go-sdk to 0.58.0 (IBM-Cloud#5652) * migration of vpc-go-sdk to 0.58.0 * make fmt changes
Ramya-c4
pushed a commit
to Ramya-c4/terraform-provider-ibm
that referenced
this pull request
Sep 27, 2024
* Added support for ibm_is_subnet_reserved_ip_patch resource * updated the name to optional * Update is_subnet_reserved_ip_patch.html.markdown
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Community Note
Relates OR Closes #0000
Output from acceptance testing: