Fix the 5635 - The ibm_resource_tag now checks the response in the api tags calls

[luiof]

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #5635

Changes:

• This PR fixes the [Bug] The ibm_resource_tag does not check the response on api tags calls #5635
• The ibm_resource_tag has been updated with the Context function and the new error handling.
• The ibm/flex/structures.go file, in particular the UpdateTagsUsingCRN function has been updated with the v1 client and a check on the results array has been added.
• The check on the results of the GhoST API has been added on all the functions to avoid issues in the resource attachment and detachment. This fix will be applied in all resources that are attaching tags since the bug is in each of them.
• Added extra tests in in the ibm_resource_tag test suite to check after the destroy.
• The delete tags call has been removed in the UpdateGlobalTagsUsingCRN function since a tag can exists on other resources and out of the terraform code too. The ibm_resource_tag must be handle only the attach and the detach.
• Removed unused structures from the GetGlobalTagsUsingCRN function.
• Added the GetTagsUsingResourceCRNFromTaggingApi function to retrieve an attached tag on a resource. This can be used in the test suite since we run them manually. I used it in the destroy step check.
• The _Wait test has been removed since it is a duplication of the _Create test.

Output from acceptance testing:

$ make testacc TEST=./ibm/service/globaltagging TESTARGS='-run=TestAccResourceTag_Basic -count=1'

2024-09-13T12:45:21.347+0200 [DEBUG] sdk.helper_resource: Finished TestCase: test_name=TestAccResourceTag_Basic
--- PASS: TestAccResourceTag_Basic (86.95s)
PASS
ok      github.com/IBM-Cloud/terraform-provider-ibm/ibm/service/globaltagging   89.638s

$ make testacc TEST=./ibm/service/globaltagging TESTARGS='-run=TestAccResourceTag_FakeCrnExpectingError -count=1'

2024-09-13T12:46:47.335+0200 [DEBUG] sdk.helper_resource: Finished TestCase: test_name=TestAccResourceTag_FakeCrnExpectingError
--- PASS: TestAccResourceTag_FakeCrnExpectingError (18.59s)
PASS
ok      github.com/IBM-Cloud/terraform-provider-ibm/ibm/service/globaltagging   20.125s

$ make testacc TEST=./ibm/service/globaltagging TESTARGS='-run=TestAccResourceTag_AttachOnExistingResource -count=1'

2024-09-13T12:48:47.025+0200 [DEBUG] sdk.helper_resource: Finished TestCase: test_name=TestAccResourceTag_AttachOnExistingResource
--- PASS: TestAccResourceTag_AttachOnExistingResource (53.15s)
PASS
ok      github.com/IBM-Cloud/terraform-provider-ibm/ibm/service/globaltagging   54.646s

$ make testacc TEST=./ibm/service/globaltagging TESTARGS='-run=TestAccResourceTag_replace_Basic -count=1'

--- PASS: TestAccResourceTag_replace_Basic (108.01s)
PASS
ok      github.com/IBM-Cloud/terraform-provider-ibm/ibm/service/globaltagging   109.560s

$ make testacc TEST=./ibm/service/globaltagging TESTARGS='-run=TestAccIamAccessTag_Basic -count=1'

2024-09-13T12:52:49.930+0200 [DEBUG] sdk.helper_resource: Finished TestCase: test_name=TestAccIamAccessTag_Basic
--- PASS: TestAccIamAccessTag_Basic (34.91s)
PASS
ok      github.com/IBM-Cloud/terraform-provider-ibm/ibm/service/globaltagging   36.430s

$ make testacc TEST=./ibm/service/globaltagging TESTARGS='-run=TestAccIamAccessTag_Usage -count=1'

2024-09-13T12:59:56.035+0200 [DEBUG] sdk.helper_resource: Finished TestCase: test_name=TestAccIamAccessTag_Usage
--- PASS: TestAccIamAccessTag_Usage (107.73s)
PASS
ok      github.com/IBM-Cloud/terraform-provider-ibm/ibm/service/globaltagging   109.264s