Add support for Code Engine functions #5596

jasonpet · 2024-08-30T16:29:11Z

Community Note

Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #0000

Output from acceptance testing:

$ make testacc
TF_ACC=1 go test -timeout 1800s -v $(go list ./... |grep -v 'vendor') 
?   	github.com/IBM-Cloud/terraform-provider-ibm	[no test files]
?   	github.com/IBM-Cloud/terraform-provider-ibm/ibm/acctest	[no test files]
?   	github.com/IBM-Cloud/terraform-provider-ibm/ibm/provider	[no test files]
?   	github.com/IBM-Cloud/terraform-provider-ibm/ibm/validate	[no test files]
?   	github.com/IBM-Cloud/terraform-provider-ibm/version	[no test files]
=== RUN   TestString
--- PASS: TestString (0.00s)
=== RUN   TestString_positiveIndex
--- PASS: TestString_positiveIndex (0.00s)
PASS
ok  	github.com/IBM-Cloud/terraform-provider-ibm/ibm/conns	0.709s
=== RUN   TestTerraformProblemEmbedsIBMProblem
--- PASS: TestTerraformProblemEmbedsIBMProblem (0.00s)
=== RUN   TestTerraformProblemGetConsoleMessage
--- PASS: TestTerraformProblemGetConsoleMessage (0.00s)
=== RUN   TestTerraformProblemGetDebugMessage
--- PASS: TestTerraformProblemGetDebugMessage (0.00s)
=== RUN   TestTerraformProblemGetID
--- PASS: TestTerraformProblemGetID (0.00s)
=== RUN   TestTerraformProblemGetConsoleOrderedMaps
--- PASS: TestTerraformProblemGetConsoleOrderedMaps (0.00s)
=== RUN   TestTerraformProblemGetDebugOrderedMaps
--- PASS: TestTerraformProblemGetDebugOrderedMaps (0.00s)
=== RUN   TestTerraformProblemGetDiag
--- PASS: TestTerraformProblemGetDiag (0.00s)
=== RUN   TestTerraformErrorf
--- PASS: TestTerraformErrorf (0.00s)
=== RUN   TestFmtErrorfWithProblem
--- PASS: TestFmtErrorfWithProblem (0.00s)
=== RUN   TestFmtErrorfWithNoError
--- PASS: TestFmtErrorfWithNoError (0.00s)
=== RUN   TestFmtErrorfWithProblemInServiceErrorResponse
--- PASS: TestFmtErrorfWithProblemInServiceErrorResponse (0.00s)
=== RUN   TestGetComponentInfo
--- PASS: TestGetComponentInfo (0.00s)
PASS
ok  	github.com/IBM-Cloud/terraform-provider-ibm/ibm/flex	0.956s
=== RUN   TestAccIbmCodeEngineAppDataSourceBasic
--- PASS: TestAccIbmCodeEngineAppDataSourceBasic (72.79s)
=== RUN   TestAccIbmCodeEngineAppDataSourceExtended
--- PASS: TestAccIbmCodeEngineAppDataSourceExtended (70.80s)
=== RUN   TestAccIbmCodeEngineBindingDataSourceBasic
--- PASS: TestAccIbmCodeEngineBindingDataSourceBasic (73.65s)
=== RUN   TestAccIbmCodeEngineBuildDataSourceBasic
--- PASS: TestAccIbmCodeEngineBuildDataSourceBasic (9.43s)
=== RUN   TestAccIbmCodeEngineConfigMapDataSourceBasic
--- PASS: TestAccIbmCodeEngineConfigMapDataSourceBasic (8.85s)
=== RUN   TestAccIbmCodeEngineDomainMappingDataSourceBasic
--- PASS: TestAccIbmCodeEngineDomainMappingDataSourceBasic (130.79s)
=== RUN   TestAccIbmCodeEngineFunctionDataSourceBasic
--- PASS: TestAccIbmCodeEngineFunctionDataSourceBasic (69.84s)
=== RUN   TestAccIbmCodeEngineFunctionDataSourceExtended
--- PASS: TestAccIbmCodeEngineFunctionDataSourceExtended (71.01s)
=== RUN   TestAccIbmCodeEngineJobDataSourceBasic
--- PASS: TestAccIbmCodeEngineJobDataSourceBasic (10.45s)
=== RUN   TestAccIbmCodeEngineJobDataSourceExtended
--- PASS: TestAccIbmCodeEngineJobDataSourceExtended (9.36s)
=== RUN   TestAccIbmCodeEngineProjectDataSourceBasic
--- PASS: TestAccIbmCodeEngineProjectDataSourceBasic (7.59s)
=== RUN   TestAccIbmCodeEngineSecretDataSourceGeneric
--- PASS: TestAccIbmCodeEngineSecretDataSourceGeneric (9.18s)
=== RUN   TestAccIbmCodeEngineSecretDataSourceBasicAuth
--- PASS: TestAccIbmCodeEngineSecretDataSourceBasicAuth (9.95s)
=== RUN   TestAccIbmCodeEngineSecretDataSourceRegistry
--- PASS: TestAccIbmCodeEngineSecretDataSourceRegistry (9.70s)
=== RUN   TestAccIbmCodeEngineSecretDataSourceSSHAuth
--- PASS: TestAccIbmCodeEngineSecretDataSourceSSHAuth (9.64s)
=== RUN   TestAccIbmCodeEngineSecretDataSourceTls
--- PASS: TestAccIbmCodeEngineSecretDataSourceTls (9.55s)
=== RUN   TestAccIbmCodeEngineSecretDataSourceServiceAccess
--- PASS: TestAccIbmCodeEngineSecretDataSourceServiceAccess (10.72s)
=== RUN   TestAccIbmCodeEngineAppBasic
--- PASS: TestAccIbmCodeEngineAppBasic (137.94s)
=== RUN   TestAccIbmCodeEngineAppExtended
--- PASS: TestAccIbmCodeEngineAppExtended (142.36s)
=== RUN   TestAccIbmCodeEngineBindingBasic
--- PASS: TestAccIbmCodeEngineBindingBasic (73.62s)
=== RUN   TestAccIbmCodeEngineBuildBasic
--- PASS: TestAccIbmCodeEngineBuildBasic (9.63s)
=== RUN   TestAccIbmCodeEngineConfigMapBasic
--- PASS: TestAccIbmCodeEngineConfigMapBasic (17.21s)
=== RUN   TestAccIbmCodeEngineDomainMappingBasic
--- PASS: TestAccIbmCodeEngineDomainMappingBasic (138.52s)
=== RUN   TestAccIbmCodeEngineFunctionBasic
--- PASS: TestAccIbmCodeEngineFunctionBasic (76.45s)
=== RUN   TestAccIbmCodeEngineFunctionExtended
--- PASS: TestAccIbmCodeEngineFunctionExtended (76.94s)
=== RUN   TestAccIbmCodeEngineJobBasic
--- PASS: TestAccIbmCodeEngineJobBasic (20.96s)
=== RUN   TestAccIbmCodeEngineJobExtended
--- PASS: TestAccIbmCodeEngineJobExtended (25.55s)
=== RUN   TestAccIbmCodeEngineProjectBasic
--- PASS: TestAccIbmCodeEngineProjectBasic (36.93s)
=== RUN   TestAccIbmCodeEngineSecretGeneric
--- PASS: TestAccIbmCodeEngineSecretGeneric (18.68s)
=== RUN   TestAccIbmCodeEngineSecretBasicAuth
--- PASS: TestAccIbmCodeEngineSecretBasicAuth (17.83s)
=== RUN   TestAccIbmCodeEngineSecretRegistry
--- PASS: TestAccIbmCodeEngineSecretRegistry (20.21s)
=== RUN   TestAccIbmCodeEngineSecretSSHAuth
--- PASS: TestAccIbmCodeEngineSecretSSHAuth (19.38s)
=== RUN   TestAccIbmCodeEngineSecretTls
--- PASS: TestAccIbmCodeEngineSecretTls (19.47s)
=== RUN   TestAccIbmCodeEngineSecretServiceAccess
--- PASS: TestAccIbmCodeEngineSecretServiceAccess (12.57s)
PASS
ok  	github.com/IBM-Cloud/terraform-provider-ibm/ibm/service/codeengine	1458.601s

...

hkantare · 2024-09-12T12:25:49Z

ibm/service/codeengine/resource_ibm_code_engine_function.go

+	hasChange := false
+
+	patchVals := &codeenginev2.FunctionPatch{}
+	if d.HasChange("project_id") {


this block is n't required when you mark ForceNew : true on "project_id" argument

hkantare · 2024-09-12T12:43:00Z

ibm/service/codeengine/resource_ibm_code_engine_function.go

+				Description:  "The name of the function.",
+			},
+			"run_env_variables": {
+				Type:        schema.TypeList,


Can we use TypeSet .
With TypeList when the order changes in user tf and in state file it always show a diff when more than one element is provided

Is there anything else that would change when switching from TypeList to TypeSet or are they mostly interchangeable?

hkantare · 2024-09-12T12:44:23Z

ibm/service/codeengine/resource_ibm_code_engine_function_test.go

+				value = "value"
+			}
+
+			lifecycle {


This block is n't required when we use TypeSet.
Adding this block restricts user's to do update of run_env_variables

Thanks you very much for reviewing our PR. I have a question from our side though. We ignore changes here, because our system injects some run_env_variables on the server-side, resulting in diffs during testing and obviously from the user's perspective. Users can react by adding those system-generated variables to the definition alongside the user-defined ones.
Are you saying that if we changed it to TypeSet, Terraform would be able to identify changes in the user-set variables only and ignore outside changes?

No TypeSet doesn't identify the changes . Can we loop , identify system-generated variables before setting back in read method?
Typeset is unordered list so it will help in controlling diff on the order of items in the list

hkantare · 2024-09-12T13:09:00Z

Resolve confiicts in .secretbaseline file

hkantare · 2024-09-16T11:33:51Z

I think we use to have same behavior in deprecated function to filter system-defined parameters/annotation

terraform-provider-ibm/ibm/flex/structures.go

Line 1269 in 7e9da7b

insert := false

jasonpet · 2024-09-16T12:38:21Z

Do you think we can get this in September? We are addressing the environment variable issue in a future PR by introducing a new computed env variable field to hold the system-defined env vars. As I mentioned before, this issue is not at all related to the current PR. So, I see no reason to hold the current PR up. The env var fields in functions are not unique to functions and exist in our existing jobs and applications resources as well.

* Add support for Code Engine functions * update .secrets.baseline * remove unnecessary check

hkantare reviewed Sep 12, 2024

View reviewed changes

jasonpet added 2 commits September 12, 2024 09:37

Add support for Code Engine functions

8906820

update .secrets.baseline

0d03a89

jasonpet force-pushed the functionsCE branch from 9d74cd4 to 0d03a89 Compare September 12, 2024 14:37

remove unnecessary check

c67e96a

hkantare approved these changes Sep 17, 2024

View reviewed changes

hkantare merged commit 1e82c33 into IBM-Cloud:master Sep 17, 2024
1 check passed

srikant-sahu pushed a commit to srikant-sahu/terraform-provider-ibm that referenced this pull request Sep 24, 2024

Add support for Code Engine functions (IBM-Cloud#5596)

a4c136f

* Add support for Code Engine functions * update .secrets.baseline * remove unnecessary check

jasonpet deleted the functionsCE branch January 15, 2025 16:21

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add support for Code Engine functions #5596

Add support for Code Engine functions #5596

jasonpet commented Aug 30, 2024

hkantare Sep 12, 2024

hkantare Sep 12, 2024

michael-magrian Sep 12, 2024

hkantare Sep 12, 2024

michael-magrian Sep 12, 2024

hkantare Sep 16, 2024

hkantare commented Sep 12, 2024

hkantare commented Sep 16, 2024

jasonpet commented Sep 16, 2024

Add support for Code Engine functions #5596

Add support for Code Engine functions #5596

Conversation

jasonpet commented Aug 30, 2024

Community Note

hkantare Sep 12, 2024

Choose a reason for hiding this comment

hkantare Sep 12, 2024

Choose a reason for hiding this comment

michael-magrian Sep 12, 2024

Choose a reason for hiding this comment

hkantare Sep 12, 2024

Choose a reason for hiding this comment

michael-magrian Sep 12, 2024

Choose a reason for hiding this comment

hkantare Sep 16, 2024

Choose a reason for hiding this comment

hkantare commented Sep 12, 2024

hkantare commented Sep 16, 2024

jasonpet commented Sep 16, 2024