Add --os=all and --arch=all options for brew audit.#15225
Merged
reitermarkus merged 2 commits intoHomebrew:masterfrom May 19, 2023
Merged
Add --os=all and --arch=all options for brew audit.#15225reitermarkus merged 2 commits intoHomebrew:masterfrom
--os=all and --arch=all options for brew audit.#15225reitermarkus merged 2 commits intoHomebrew:masterfrom
Conversation
MikeMcQuaid
reviewed
Apr 14, 2023
08fd0d4 to
814115b
Compare
reitermarkus
commented
Apr 21, 2023
d0d4251 to
3257f50
Compare
21d858c to
2f8f30d
Compare
MikeMcQuaid
reviewed
May 8, 2023
Member
MikeMcQuaid
left a comment
There was a problem hiding this comment.
This is looking good so far! I have to be honest and say that I haven't given every line detailed review. Is there any way to split this into multiple, smaller PRs for review before merge?
Similarly, I have mild concerns with the amount of code that's not covered by any tests but want to avoid adding new integration tests for all these commands. Suggestions welcome, may not be blocking.
Thanks again @reitermarkus, great work here.
628f972 to
83f3ea7
Compare
This was referenced May 13, 2023
Merged
f2a8311 to
b812864
Compare
7 tasks
b812864 to
5e4ab41
Compare
5e4ab41 to
0782df8
Compare
MikeMcQuaid
reviewed
May 17, 2023
Member
MikeMcQuaid
left a comment
There was a problem hiding this comment.
Looking good! A few questions and thoughts here but nothing major. Nice work @reitermarkus!
0782df8 to
a97e63e
Compare
MikeMcQuaid
approved these changes
May 18, 2023
Member
MikeMcQuaid
left a comment
There was a problem hiding this comment.
One style nit if you can be bothered but fine if this ships as-is. Thanks again @reitermarkus!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
brew stylewith your changes locally?brew typecheckwith your changes locally?brew testswith your changes locally?Needs to be rebased onto #15201.