remove cask/cmd/audit

[hyuraku]

• Have you followed the guidelines in our Contributing document?
• Have you checked to ensure there aren't other open Pull Requests for the same change?
• Have you added an explanation of what your changes do and why you'd like us to include them?
• Have you written new tests for your changes? Here's an example.
• Have you successfully run brew style with your changes locally?
• Have you successfully run brew typecheck with your changes locally?
• Have you successfully run brew tests with your changes locally?

---

remove cask/cmd/audit because of #14799

[MikeMcQuaid]

Great work so far!

[MikeMcQuaid]

Can these get passed through directly as named parameters rather than an options hash? Thanks!

[MikeMcQuaid]

Suggested change

	[cask.sourcefile_path, { errors: Cask::Auditor.audit(
	cask,
	# For switches, we add `|| nil` so that `nil` will be passed
	# instead of `false` if they aren't set.
	# This way, we can distinguish between "not set" and "set to false".
	audit_download: nil,
	audit_online: (args.online? || nil),
	audit_strict: (args.strict? || nil),
	# No need for `|| nil` for `--[no-]signing`
	# because boolean switches are already `nil` if not passed
	audit_signing: args.signing?,
	audit_new_cask: (args.new_cask? || nil),
	audit_token_conflicts: (args.token_conflicts? || nil),
	quarantine: true,
	language: nil,
	any_named_args: !no_named_args,
	only: args.only,
	except: args.except,
	), warnings: [] }]
	errors = Cask::Auditor.audit(
	cask,
	# For switches, we add `|| nil` so that `nil` will be passed
	# instead of `false` if they aren't set.
	# This way, we can distinguish between "not set" and "set to false".
	audit_download: nil,
	audit_online: (args.online? || nil),
	audit_strict: (args.strict? || nil),
	# No need for `|| nil` for `--[no-]signing`
	# because boolean switches are already `nil` if not passed
	audit_signing: args.signing?,
	audit_new_cask: (args.new_cask? || nil),
	audit_token_conflicts: (args.token_conflicts? || nil),
	quarantine: true,
	language: nil,
	any_named_args: !no_named_args,
	only: args.only,
	except: args.except,
	)
	[cask.sourcefile_path, errors]

bit nicer to do this outside the array and warnings are never used any more so nicer to strip them out

[MikeMcQuaid]

Suggested change

	failed_casks = cask_results.reject { |_, result| result[:errors].empty? }
	failed_casks = cask_results.reject { |_, errors| errors.empty? }

below here: all references to result[:warnings] can be removed and result[: errors] replaced with just result/errors because, if you apply suggestions above, warnings is never set/used and errors is the hash value.

[issyl0]

Hurray, this was a TODO that I wrote a note about in 8319c8f so it's great if this gets done.

[MikeMcQuaid]

@hyuraku nudge on this!

[MikeMcQuaid]

Opened #15269 for this.

[reitermarkus]

Do we need to pass this explicitly as nil?

[MikeMcQuaid]

Thanks @hyuraku!