Enable Sorbet/TrueSigil cop

[dduugg]

• Have you followed the guidelines in our Contributing document?
• Have you checked to ensure there aren't other open Pull Requests for the same change?
• Have you added an explanation of what your changes do and why you'd like us to include them?
• Have you written new tests for your changes? Here's an example.
• Have you successfully run brew style with your changes locally?
• Have you successfully run brew typecheck with your changes locally?
• Have you successfully run brew tests with your changes locally?

---

As the remaining un-typed files were removed in #15201 and #15273, this PR enables a cop that requires files to be typed. The configuration is taken from Sorbet/FalseSigil above it, with the exception of excluding all Homebrew/test files.

[issyl0]

On the "ignore tests" part, I don't know anything about the desired state of typechecking test files - is this a thing that is never going to be done, or might be when the landscape is better, or should be done now or incrementally when people get time? I wonder what would happen if we set typed: true for tests. 🤔

[dduugg]

On the "ignore tests" part, I don't know anything about the desired state of typechecking test files - is this a thing that is never going to be done, or might be when the landscape is better, or should be done now or incrementally when people get time? I wonder what would happen if we set typed: true for tests. 🤔

I've managed to do it in a gem by introducing an rspec context that i typecheck independently of the rest of the code. I think the main issue here would bethat any test using let would fail.

[issyl0]

Ah, we use a lot of let. Good to know, though, interesting! Feel free to merge this, and thank you for your efforts to move the needle on our Sorbet adoption - this is great.

[MikeMcQuaid]

I don't know anything about the desired state of typechecking test files - is this a thing that is never going to be done

IMO: it's not worth type checking these files at all and I'd favour even removing the typed: false on those files to indicate this.

[MikeMcQuaid]

Thanks again @dduugg!

[dduugg]

I don't know anything about the desired state of typechecking test files - is this a thing that is never going to be done

IMO: it's not worth type checking these files at all and I'd favour even removing the typed: false on those files to indicate this.

That's a reasonable stylistic choice, since typed:false is the default setting. Sorbet/FalseSigil will need to be disabled (or re-scoped), then a sed find-and-replace should clean things up. I can take, feel free to file a ticket and assign to me to confirm that's the desired outcome.

[MikeMcQuaid]

@dduugg Done: #15281

Another thing worth considering (I can make an issue again if helpful): enabling Sorbet/EnforceSignatures now that we have Sorbet/TrueSigil. I've seen some usage of typed: strict which I don't think we should (ever) use and, on my work project, Sorbet/EnforceSignatures feels like a good middle ground.