Add SimulateSystem::with.#15420
Merged
reitermarkus merged 1 commit intoHomebrew:masterfrom May 14, 2023
Merged
Conversation
apainintheneck
approved these changes
May 14, 2023
Contributor
apainintheneck
left a comment
apainintheneck
left a comment
There was a problem hiding this comment.
This refactor is really great.
| cache_key = :"#{platform}_#{arch}_#{macos_version}" | ||
|
|
||
| @dependent_hash[cache_key] ||= begin | ||
| all = eval_all || Homebrew::EnvConfig.eval_all? |
Contributor
There was a problem hiding this comment.
I assume that Homebrew::EnvConfig.eval_all? isn't needed here anymore because we already pass it in manually somewhere else?
Member
Author
There was a problem hiding this comment.
Yes, all callers already pass this explicitly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extracted from #15225.