fix: UI in many screens was broken because of flex 1 #171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andreabadesso
approved these changes
May 18, 2022
r4mmer
approved these changes
May 18, 2022
andreabadesso
approved these changes
May 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
We've added a
flex: 1to the AmountInput component to fix a bug in the android app in the SendAmountInput screen when deleting all the text (the bug is described here facebook/react-native#30666).This fix ended up breaking many screens in all devices (this can be seen in the videos added in this PR #168 or in the images below).
The fix was to remove the generic
flex: 1and add it as a custom style only for the SendAmountInput screen. This makes all the screens to work in both android and iOS.Acceptance Criteria
Security Checklist
Bug in iOS:
Bug in Android:
Correct screen after the fix: