Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Biometry options #168

Merged
merged 1 commit into from
May 19, 2022
Merged

feat: Biometry options #168

merged 1 commit into from
May 19, 2022

Conversation

r4mmer
Copy link
Member

@r4mmer r4mmer commented May 17, 2022

Acceptance Criteria

  • Enable fingerprint and face id biometry options

Security Checklist

  • Make sure you do not include new dependencies in the project unless strictly necessary and do not include dev-dependencies as production ones. More dependencies increase the possibility of one of them being hijacked and affecting us.

@r4mmer r4mmer added the enhancement New feature or request label May 17, 2022
@r4mmer r4mmer requested a review from andreabadesso May 17, 2022 14:11
@r4mmer r4mmer self-assigned this May 17, 2022
@pedroferreira1
Copy link
Member

Tests in iOS devices:

iPhone 7 with touch ID:

RPReplay_Final1652822193.MP4

iPhone 13 mini with face ID:

RPReplay_Final1652822417.MP4

@r4mmer
Copy link
Member Author

r4mmer commented May 18, 2022 •
edited
Loading

Android (Moto G9 Plus) with fingerprint

WhatsApp.Video.2022-05-17.at.9.51.11.PM.mp4

@pedroferreira1 pedroferreira1 mentioned this pull request May 18, 2022
Merged
1 task
@r4mmer r4mmer merged commit 34523e3 into dev May 19, 2022
@r4mmer r4mmer deleted the feat/more-biometry-options branch May 19, 2022 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andreabadesso andreabadesso andreabadesso approved these changes

@pedroferreira1 pedroferreira1 pedroferreira1 approved these changes

Assignees

@r4mmer r4mmer

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@r4mmer @pedroferreira1 @andreabadesso