Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: UI in many screens was broken because of flex 1 #171

Merged
merged 3 commits into from
May 18, 2022
Merged

fix: UI in many screens was broken because of flex 1 #171

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
239bd71
fix: UI in many screens was broken because of flex 1
pedroferreira1 May 18, 2022
3ead8d8
docs: add comment to new flex 1 style
pedroferreira1 May 18, 2022
a840d7b
chore: fix linter
pedroferreira1 May 18, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion src/components/AmountTextInput.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,6 @@ class AmountTextInput extends React.Component {

const style = StyleSheet.create({
input: {
flex: 1,
height: 38,
lineHeight: 38,
fontSize: 32,
Expand Down
3 changes: 3 additions & 0 deletions src/screens/SendAmountInput.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -156,6 +156,9 @@ class SendAmountInput extends React.Component {
onAmountUpdate={this.onAmountChange}
value={this.state.amount}
allowOnlyInteger={this.isNFT()}
style={{ flex: 1 }} // we need this so the placeholder doesn't break in android
// devices after erasing the text
// https://github.com/facebook/react-native/issues/30666
/>
{IS_MULTI_TOKEN
? <TokenBox onPress={this.onTokenBoxPress} label={this.state.token.symbol} />
Expand Down