Skip to content
This repository was archived by the owner on Feb 18, 2025. It is now read-only.

Conversation

@braughtg
Copy link
Collaborator

@braughtg braughtg commented Jan 13, 2025

Pull Request Description

All changes made in the January 2025 sprint will be merged to this branch. Then this branch will be merged into main to update the text on runestone.

The most significant changes include:

  • Migration to the Codespaces KitClient
  • Updates to lots of questions to make them autogradable.
  • Change from using a merge tool, to editing raw merge info in VSCode.

Be sure to complete the following before merging:


Licensing Certification

GitKit is a Free Cultural Work and all accepted contributions are licensed as described in the LICENSE.md file. This requires that the contributor holds the rights to do so. By submitting this pull request I certify that I satisfy the terms of the Developer Certificate of Origin for its contents.

braughtg and others added 30 commits January 13, 2025 18:46
`DevEnv-Request-PAT.png` shows the prompt for the PAT.
`DevEnv-Blank-Ready.png` shows the environment with no open folder and the Kit ready message.
**Pull Request Description**

Closes #89 

---

**Licensing Certification**

GitKit is a [Free Cultural Work](https://freedomdefined.org/Definition)
and all accepted contributions are licensed as described in the
LICENSE.md file. This requires that the contributor holds the rights to
do so. By submitting this pull request **I certify that I satisfy the
terms of the [Developer Certificate of
Origin](https://developercertificate.org/)** for its contents.
**Pull Request Description**

Updates to Chapter 4 from the January 2025 Sprint.

Partial completion of #92.

---

**Licensing Certification**

GitKit is a [Free Cultural Work](https://freedomdefined.org/Definition)
and all accepted contributions are licensed as described in the
LICENSE.md file. This requires that the contributor holds the rights to
do so. By submitting this pull request **I certify that I satisfy the
terms of the [Developer Certificate of
Origin](https://developercertificate.org/)** for its contents.
**Pull Request Description**

_Describe what your Pull Request does here_
This PR contains updates to Ch. 3 - Upstreaming Changes.

_Include a "Closes #" line for any issues that your PR closes._

---

**Licensing Certification**

GitKit is a [Free Cultural Work](https://freedomdefined.org/Definition)
and all accepted contributions are licensed as described in the
LICENSE.md file. This requires that the contributor holds the rights to
do so. By submitting this pull request **I certify that I satisfy the
terms of the [Developer Certificate of
Origin](https://developercertificate.org/)** for its contents.
**Pull Request Description**

Escapes the . in regular expression checks for `user.name` and
`user.email`.

Closes #121 
Closes #122 

---

**Licensing Certification**

GitKit is a [Free Cultural Work](https://freedomdefined.org/Definition)
and all accepted contributions are licensed as described in the
LICENSE.md file. This requires that the contributor holds the rights to
do so. By submitting this pull request **I certify that I satisfy the
terms of the [Developer Certificate of
Origin](https://developercertificate.org/)** for its contents.
**Pull Request Description**

Completes all revisions for Chapter 2 - except for 2.8.1.c - consider
blurring the username and repo name in the URL in the image.

Closes #90

---

**Licensing Certification**

GitKit is a [Free Cultural Work](https://freedomdefined.org/Definition)
and all accepted contributions are licensed as described in the
LICENSE.md file. This requires that the contributor holds the rights to
do so. By submitting this pull request **I certify that I satisfy the
terms of the [Developer Certificate of
Origin](https://developercertificate.org/)** for its contents.
**Pull Request Description**

_Describe what your Pull Request does here_

Updates Chapter 3 based to fix problems found during the proofreading
process.

_Include a "Closes #" line for any issues that your PR closes._

---

**Licensing Certification**

GitKit is a [Free Cultural Work](https://freedomdefined.org/Definition)
and all accepted contributions are licensed as described in the
LICENSE.md file. This requires that the contributor holds the rights to
do so. By submitting this pull request **I certify that I satisfy the
terms of the [Developer Certificate of
Origin](https://developercertificate.org/)** for its contents.
**Pull Request Description**

Revises chapter 5.

Closes #94
Closes #93

---

**Licensing Certification**

GitKit is a [Free Cultural Work](https://freedomdefined.org/Definition)
and all accepted contributions are licensed as described in the
LICENSE.md file. This requires that the contributor holds the rights to
do so. By submitting this pull request **I certify that I satisfy the
terms of the [Developer Certificate of
Origin](https://developercertificate.org/)** for its contents.
**Pull Request Description**

Patches a bad xref in chapter 5.

---

**Licensing Certification**

GitKit is a [Free Cultural Work](https://freedomdefined.org/Definition)
and all accepted contributions are licensed as described in the
LICENSE.md file. This requires that the contributor holds the rights to
do so. By submitting this pull request **I certify that I satisfy the
terms of the [Developer Certificate of
Origin](https://developercertificate.org/)** for its contents.
**Pull Request Description**

Revisions to the Instructor guide.

Closes #103 

---

**Licensing Certification**

GitKit is a [Free Cultural Work](https://freedomdefined.org/Definition)
and all accepted contributions are licensed as described in the
LICENSE.md file. This requires that the contributor holds the rights to
do so. By submitting this pull request **I certify that I satisfy the
terms of the [Developer Certificate of
Origin](https://developercertificate.org/)** for its contents.
**Pull Request Description**

Cleans up deprecated document information, applies the salem style with
"leaves" color palette.
Also removes some unused images.

Closes #158 
Closes #160 
Closes #168

---

**Licensing Certification**

GitKit is a [Free Cultural Work](https://freedomdefined.org/Definition)
and all accepted contributions are licensed as described in the
LICENSE.md file. This requires that the contributor holds the rights to
do so. By submitting this pull request **I certify that I satisfy the
terms of the [Developer Certificate of
Origin](https://developercertificate.org/)** for its contents.
**Pull Request Description**

Edits and remaining revisions to chapter 4.

Closes #92 
Closed #149 

---

**Licensing Certification**

GitKit is a [Free Cultural Work](https://freedomdefined.org/Definition)
and all accepted contributions are licensed as described in the
LICENSE.md file. This requires that the contributor holds the rights to
do so. By submitting this pull request **I certify that I satisfy the
terms of the [Developer Certificate of
Origin](https://developercertificate.org/)** for its contents.
**Pull Request Description**

Some small updates and edits in chapter 2.

---

**Licensing Certification**

GitKit is a [Free Cultural Work](https://freedomdefined.org/Definition)
and all accepted contributions are licensed as described in the
LICENSE.md file. This requires that the contributor holds the rights to
do so. By submitting this pull request **I certify that I satisfy the
terms of the [Developer Certificate of
Origin](https://developercertificate.org/)** for its contents.
**Pull Request Description**

Clarifies language on 2.4.2.1.d hint.

---

**Licensing Certification**

GitKit is a [Free Cultural Work](https://freedomdefined.org/Definition)
and all accepted contributions are licensed as described in the
LICENSE.md file. This requires that the contributor holds the rights to
do so. By submitting this pull request **I certify that I satisfy the
terms of the [Developer Certificate of
Origin](https://developercertificate.org/)** for its contents.


Co-authored-by: karl@w-sts.com
**Pull Request Description**

Chapter 3 revisions by @kwurst 

---

**Licensing Certification**

GitKit is a [Free Cultural Work](https://freedomdefined.org/Definition)
and all accepted contributions are licensed as described in the
LICENSE.md file. This requires that the contributor holds the rights to
do so. By submitting this pull request **I certify that I satisfy the
terms of the [Developer Certificate of
Origin](https://developercertificate.org/)** for its contents.


Co-authored-by: kwurst <karl@w-sts.com>

---------

Co-authored-by: Karl R. Wurst <karl@w-sts.com>
**Pull Request Description**

Makes some edits to chapter 4. The most significant was to revise
Section 4.3 because Codespaces automatically sets the upstream remote
when you open the cloned/forked repo.

Closes #178 

---

**Licensing Certification**

GitKit is a [Free Cultural Work](https://freedomdefined.org/Definition)
and all accepted contributions are licensed as described in the
LICENSE.md file. This requires that the contributor holds the rights to
do so. By submitting this pull request **I certify that I satisfy the
terms of the [Developer Certificate of
Origin](https://developercertificate.org/)** for its contents.
**Pull Request Description**

Fixes issues in chapter 5.

Closes #181 

---

**Licensing Certification**

GitKit is a [Free Cultural Work](https://freedomdefined.org/Definition)
and all accepted contributions are licensed as described in the
LICENSE.md file. This requires that the contributor holds the rights to
do so. By submitting this pull request **I certify that I satisfy the
terms of the [Developer Certificate of
Origin](https://developercertificate.org/)** for its contents.
**Pull Request Description**

Clarifies locations where "GitKit-FarmData2" were used because
instructors may have given their upstream repository a different name.
Text now uses more generic phrases such as "the directory for your local
GitKit FarmData2" repository or "the GitKit FarmData2 upstream
repository".

Closes #176

---

**Licensing Certification**

GitKit is a [Free Cultural Work](https://freedomdefined.org/Definition)
and all accepted contributions are licensed as described in the
LICENSE.md file. This requires that the contributor holds the rights to
do so. By submitting this pull request **I certify that I satisfy the
terms of the [Developer Certificate of
Origin](https://developercertificate.org/)** for its contents.
**Pull Request Description**

A number of `xml:id` and `label` values included `-linux` which is a
holdover from the `linux` edition. The `-linux` was removed from these
values.

Closes #164 

---

**Licensing Certification**

GitKit is a [Free Cultural Work](https://freedomdefined.org/Definition)
and all accepted contributions are licensed as described in the
LICENSE.md file. This requires that the contributor holds the rights to
do so. By submitting this pull request **I certify that I satisfy the
terms of the [Developer Certificate of
Origin](https://developercertificate.org/)** for its contents.
**Pull Request Description**

Checks all of the regex for:
- escaped `.` in expressions.
- inclusion of `.*` catch all.
- Some coverage of likely cases (but could still be improved).

Closes #137 
Closes #157 

---

**Licensing Certification**

GitKit is a [Free Cultural Work](https://freedomdefined.org/Definition)
and all accepted contributions are licensed as described in the
LICENSE.md file. This requires that the contributor holds the rights to
do so. By submitting this pull request **I certify that I satisfy the
terms of the [Developer Certificate of
Origin](https://developercertificate.org/)** for its contents.
**Pull Request Description**

Ensures that all `introduction`, `statement` and `hint` elements use
`<p>` elements.

Closes #156 

---

**Licensing Certification**

GitKit is a [Free Cultural Work](https://freedomdefined.org/Definition)
and all accepted contributions are licensed as described in the
LICENSE.md file. This requires that the contributor holds the rights to
do so. By submitting this pull request **I certify that I satisfy the
terms of the [Developer Certificate of
Origin](https://developercertificate.org/)** for its contents.
@braughtg
Copy link
Collaborator Author

This PR has been moved to the new GitKit-Codespace repo.

@braughtg braughtg closed this Feb 17, 2025
@braughtg braughtg deleted the jan-25-sprint branch February 18, 2025 19:18
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants