Skip to content

Bulk rename gcore -> gstd in editor #2729

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 4 commits into
base: master
Choose a base branch
from
Draft

Bulk rename gcore -> gstd in editor #2729

wants to merge 4 commits into from
+213 −215

Conversation

Firestar99
Copy link
Collaborator

@Firestar99 Firestar99 commented Jun 17, 2025 •
edited
Loading

Requires #2733

bulk renames, for code changes see #2729

@Firestar99 Firestar99 changed the title bulk rename gcore -> gstd in editor Bulk rename gcore -> gstd in editor Jun 18, 2025
@TrueDoctor
Copy link
Member

TrueDoctor commented Jun 18, 2025 •
edited
Loading

I'm adding reexports, and the node macro generated mod image is conflicting with reexporting gcore::raster::image in gstd. May have to rename it, not sure to what.

Can you rexport gcore::raster::* from inside gstd::raster?

@TrueDoctor
Copy link
Member

And you could rename the gcore::raster module to something else to avoid coflicts. Then we don't have to rename anything in editor

Firestar99
Firestar99 commented Jun 18, 2025
View reviewed changes
node-graph/gstd/src/raster.rs
use graphene_core::raster::image::{Image, RasterDataTable};
use graphene_core::raster::{Alpha, AlphaMut, Bitmap, BitmapMut, CellularDistanceFunction, CellularReturnType, Channel, DomainWarpType, FractalType, LinearChannel, Luminance, NoiseType, RGBMut};
use graphene_core::raster::image::RasterDataTable;
pub use graphene_core::raster::*;
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@TrueDoctor that's the reexport I added. But since this mod already contains a mod image through the node macro, that mod takes priority over the glob reexport. And I can't insert a glob reexport into the image mod itself, since it's fully contained within the node macro's output.

@Firestar99
Copy link
Collaborator Author

And you could rename the gcore::raster module to something else to avoid coflicts. Then we don't have to rename anything in editor

This PR makes editor to only depend on gstd and removes it's dependency on gcore. Instead, all of gcore is reexported in gstd. This allows me to rip apart gcore without editor being affected, as long as I continue to reexport all nodes in gstd. Saving us a lot of conflicts down the line.

@Firestar99 Firestar99 force-pushed the editor_gcore_splitup_prep branch from 0215b5a to c182610 Compare June 18, 2025 11:10
@Firestar99 Firestar99 force-pushed the editor_gcore_splitup_prep branch from c182610 to 1bcf60c Compare June 18, 2025 11:17
This was referenced Jun 18, 2025
Open
Draft
@Firestar99 Firestar99 force-pushed the editor_gcore_splitup_prep branch from 1bcf60c to 8c7b22e Compare June 18, 2025 13:20
@Firestar99 Firestar99 marked this pull request as ready for review June 18, 2025 13:42
@Firestar99 Firestar99 marked this pull request as draft June 18, 2025 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Firestar99 @TrueDoctor