Reexport all of gcore in gstd, rename image node to image_value
#2733
+14
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Firestar99
force-pushed
the
rename_image_node
branch
from
37d6a5a to
3cb74fe
Compare
Firestar99
changed the title
gcore in gstd, Rename image node to image_valuegcore in gstd, rename image node to image_value
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires #2723
code changes, for bulk renames see #2729
This PR and #2729 makes
editorto only depend ongstdand removes it's dependency ongcore. Instead, all ofgcoreis reexported ingstd. This allows me to rip apartgcorewithouteditorbeing affected, as long as I continue to reexport all nodes ingstd. Saving us a lot of conflicts down the line.