Make gcore a std library, remove std, alloc and more unused features
#2724
+333
−489
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Firestar99
commented
Jun 16, 2025
node-graph/gcore/src/types.rs
Outdated
| @@ -144,7 +141,7 @@ fn migrate_type_descriptor_names<'de, D: serde::Deserializer<'de>>(deserializer: | |||
| let name = String::deserialize(deserializer)?; | |||
| let name = match name.as_str() { | |||
| "f32" => "f64".to_string(), | |||
| "graphene_core::transform::Footprint" => "core::option::Option<alloc::sync::Arc<graphene_core::context::OwnedContextImpl>>".to_string(), | |||
| "graphene_core::transform::Footprint" => "std::option::Option<std::sync::Arc<graphene_core::context::OwnedContextImpl>>".to_string(), | |||
There was a problem hiding this comment.
I'm unsure whether this will cause breakage or not. While core would still compile, alloc shouldn't since I removed the external crate alloc;. Even if this particular migration code may be fine to be changed, it could indicate trouble with other documents in the wild. At least the demo artworks are unaffected.
There was a problem hiding this comment.
This only affects the debug output, a breakage here is fine.
Firestar99
force-pushed
the
gcore_feature_removal
branch
from
66e683a to
b7104e3
Compare
Firestar99
force-pushed
the
gcore_feature_removal
branch
from
b7104e3 to
3f17504
Compare
Firestar99
changed the title
Firestar99
changed the title
gcore
…lways available
Firestar99
force-pushed
the
gcore_feature_removal
branch
from
a6b9c4d to
a916e5d
Compare
Firestar99
changed the title
gcoregcore an std library, remove unused features
Firestar99
changed the title
gcore an std library, remove unused features gcore a std library, remove std, alloc and more unused features
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires #2729
This PR contains the code changes, for bulk renames see #2735