Skip to content
This repository was archived by the owner on Feb 6, 2025. It is now read-only.

Fixes #1

Merged
merged 46 commits into from
Apr 2, 2020
Merged
Changes from 1 commit
Commits
Show all changes
46 commits
Select commit Hold shift + click to select a range
f67ea04
had to change (lower) MINIMUM_D3D_FEATURE_LEVEL to make it work with …
dsuoch-intel Mar 31, 2020
1cb0262
fixed DX resource leak (ImGui) on shutdown
dsuoch-intel Mar 31, 2020
79bc41d
C++ best practices: dynamic resource allocation
dsuoch-intel Mar 31, 2020
14fb404
fixed warning: 'WaitForGpu' overrides a member function but is not ma…
dsuoch-intel Mar 31, 2020
fcf94c7
improved project settings
dsuoch-intel Mar 31, 2020
44ccdc1
added "standard" windows defines (WIN32_LEAN_AND_MEAN, VC_EXTRALEAN, …
dsuoch-intel Mar 31, 2020
ef101b9
fixed warnings - C4100: unreferenced formal parameter / unused parameter
dsuoch-intel Mar 31, 2020
994e0b6
fixed warnings - C4189: local variable is initialized but not referen…
dsuoch-intel Mar 31, 2020
980adfa
fixed warnings - comparison of integers of different signs: 'int' an…
dsuoch-intel Mar 31, 2020
7a49418
fixed warnings - C4456: declaration hides previous local declaration
dsuoch-intel Mar 31, 2020
80c9712
fixed warning - unused variable
dsuoch-intel Mar 31, 2020
03845b9
fixed warning - private field is not used
dsuoch-intel Mar 31, 2020
8c77279
fixed warnings - C26495: variable is uninitialized. Always initializ…
dsuoch-intel Mar 31, 2020
b2c64de
be more consistent about WRL (use full qualified name or using statem…
dsuoch-intel Mar 31, 2020
4f46402
improve included headers (remove unused and duplicates, sort / group,…
dsuoch-intel Mar 31, 2020
f1c606b
const member functions
dsuoch-intel Mar 31, 2020
2b27f7c
fix for check for UMA feature
dsuoch-intel Mar 31, 2020
63ba512
made 1 parameter constructors explicit
dsuoch-intel Mar 31, 2020
a37c778
fixed warning - non-static data member shadows inherited member
dsuoch-intel Mar 31, 2020
3771504
mark overridden methods also virtual
dsuoch-intel Mar 31, 2020
fa7d0e2
improved string handling for shader loading (less allocations/copies,…
dsuoch-intel Apr 1, 2020
7c5b037
fixed fence event handle leak in destructors
dsuoch-intel Apr 1, 2020
aa1ba21
fixes to timers (initialization, const, pass string by const referenc…
dsuoch-intel Apr 1, 2020
a52b219
check return value of wait functions
dsuoch-intel Apr 1, 2020
ba02668
improve check for DXGI_FEATURE_PRESENT_ALLOW_TEARING support
dsuoch-intel Apr 1, 2020
6e89e8d
wrapped remaining D3D12 functions in ThrowIfFailed or assert
dsuoch-intel Apr 1, 2020
4f6bf89
const fixes
dsuoch-intel Apr 1, 2020
e2475e7
slightly better shader error handling
dsuoch-intel Apr 1, 2020
a51650e
marked WinAPI functions with anonymous namespace lookup
dsuoch-intel Apr 1, 2020
8786f12
couple of const stragglers
dsuoch-intel Apr 1, 2020
3ff7285
nullptr
dsuoch-intel Apr 1, 2020
be1a14f
forgot some checks
dsuoch-intel Apr 1, 2020
4f16bba
proper teardown if window can't be created
dsuoch-intel Apr 1, 2020
fd7028d
fixes for ctor / initialization list
dsuoch-intel Apr 1, 2020
296e7e2
fixed another leak (when switching device for RenderQueue)
dsuoch-intel Apr 1, 2020
2d71e4a
improved ExtensionHelper
dsuoch-intel Apr 1, 2020
18da49e
couple more fixes
dsuoch-intel Apr 1, 2020
26f2781
white space, formatting
dsuoch-intel Apr 1, 2020
89b2be8
optimized LoadParticles()
dsuoch-intel Apr 1, 2020
bbd1dc4
DXGI interface changes, plugged another leak
dsuoch-intel Apr 1, 2020
613216b
extended reach of IMGUI_ENABLED
dsuoch-intel Apr 1, 2020
f92be8b
minor changes
dsuoch-intel Apr 1, 2020
c6312ff
accidentally broke window size/pos restore after going out of fullscreen
dsuoch-intel Apr 1, 2020
50103aa
fixed another leak when switching between windowed and fullscreen
dsuoch-intel Apr 1, 2020
4f062f5
fixed more leaks when toggling INTC queue extension (seems to interna…
dsuoch-intel Apr 2, 2020
55d8cfa
minor changes (added some asserts, disabled particle loading benchmar…
dsuoch-intel Apr 2, 2020
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fixed warning - unused variable
  • Loading branch information
dsuoch-intel committed Mar 31, 2020
commit 80c9712c229d4f232b5fbc0026506940dd600105
1 change: 0 additions & 1 deletion Particles/Compute.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -629,7 +629,6 @@ void Compute::InitializeParticles()
nullptr,
IID_PPV_ARGS(&velocityBufferUpload)));

D3D12_SUBRESOURCE_DATA velocityData = {};
particleData.pData = reinterpret_cast<UINT8*>(&velocities[0]);
particleData.RowPitch = velocityBufferSize;
particleData.SlicePitch = particleData.RowPitch;
Expand Down