This repository was archived by the owner on Feb 6, 2025. It is now read-only.
Fixes #1
Merged
Fixes #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…my Quadro M1000M (driver 442.74). CreateDevice could be improved by trying highest level first and falling back to lower levels
base and derived classes allocate resources, so at least deleted copy constructor, copy assignment operator, move constructor and move assignment operator if Compute or Render were deleted by base pointer we would already have a memory leak (see warning "delete called on non-final class instance that has virtual functions but non-virtual destructor")
- increased warning level in debug build configuration. had to disable some warnings because of dreaded D3D12X library - disabled FP exceptions, enabled fast math (not important in this demo) - set standard to C++14 (basically C++11 with fixes) -> best for compatibility - disabled RTTI (not used) - enabled faster multiprocessor compilation
…STRICT, NOMINMAX) to project
…ced / unused variable
… a member variable (type.6).
… use fwd declarations)
… less redundant work)
…e instead of hoping for copy elision)
-do certain things really only if Intel device -prevent copy,move,assignment -remove unnecessary code -const fixes -added more checks
-unnecessary delete -using correct interface versions (Win10 DX12 base line) -don't use unnecessary temporary variables -check return values -const fixes
this part of the start up was excruciating slow, especially in debug (10s in total) so I optimized some of the CPU code using this better rand() alternative https://software.intel.com/en-us/articles/fast-random-number-generator-on-the-intel-pentiumr-4-processor results on my machine (i7-6820HQ 4C8T @ 2.7GHz) with Visual Studio 2019 (16.4.5): * Debug (via Debugger) USE_ORIG avg ~5s (x2) USE_SCALAR_OPTIMIZED avg ~1.2s (x2) USE_SIMD_OPTIMIZED avg ~1.2s (x2) * Release (via Debugger, NO_DEBUG_HEAP) USE_ORIG avg ~1.9s (x2) USE_SCALAR_OPTIMIZED avg ~0.05s (x2) USE_SIMD_OPTIMIZED avg ~0.05s (x2)
MSDN warning: "Do not mix the use of DXGI 1.0 (IDXGIFactory) and DXGI 1.1 (IDXGIFactory1) in an application. Use IDXGIFactory or IDXGIFactory1, but not both in an application." https://docs.microsoft.com/en-us/windows/win32/api/dxgi/nf-dxgi-createdxgifactory
…lly increase ref count)
…k output, formatting)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.