Fixed Shift combinations with different keyboard layouts

[najlkin]

This is a possible fix for #308 . Please test it!

[justinlaughlin]

Something funky going on with test 11 mesh-explorer on mac 👀

[najlkin]

What is that !? 🙃

[najlkin]

Can you test it @justinlaughlin ? I do not have a Mac 🍏 ...

[justinlaughlin]

Can you test it @justinlaughlin ? I do not have a Mac 🍏 ...

I don't have one either unfortunately 🏠🐧

[najlkin]

Ok, I maybe know what happens, SdlWindow::signalKeyDown() generates also these key down events, but does not initialize the scan code, which did not matter before, but matters now 🤔 .

[najlkin]

Hmm, some keys are translated strangely to scan codes, but still ASCII, so the code works 😉
Edit: Nope, some are translated to zero and processed in keyDownEvent() instead of textInputEvent(), but somehow luckily it works 🙃

[najlkin]

Ok, still some keys are handled in keyDownEvent() instead of textInputEvent(), but it does not matter, I would say, as the called functions are identified by the key code, which is always correct from signalKeyDown().

[tzanio]

I can confirm that the latest commit shows the mesh-explorer test correctly on my mac

[tzanio]

I tested some more, and this appears to work as before with the standard layout on Mac

[justinlaughlin]

FWIW, tested mesh-explorer on WSL and it seems to be fine.

[najlkin]

@justinlaughlin Do you have different layouts than the US?

[justinlaughlin]

@justinlaughlin Do you have different layouts than the US?

Just USA 🦅