Skip to content

Fixed visualization of extruded 1D meshes#307

Merged
tzanio merged 4 commits intomasterfrom
najlkin/fix-1D-mesh
Aug 17, 2024
Merged

Fixed visualization of extruded 1D meshes#307
tzanio merged 4 commits intomasterfrom
najlkin/fix-1D-mesh

Conversation

@najlkin
Copy link
Copy Markdown
Contributor

@najlkin najlkin commented Aug 13, 2024

This PR fixes visualization of 1D meshes, which are incorrectly recognized as coarse meshes of quadratures, since 1D meshes are backed up before the extrusion (to be used with different representations of quadratures).

Reported by: @vladotomov

TODO:

  • Add 1D test

@najlkin najlkin added the bug label Aug 13, 2024
@najlkin najlkin requested a review from vladotomov August 13, 2024 16:57
@najlkin najlkin self-assigned this Aug 13, 2024
@v-dobrev v-dobrev mentioned this pull request Aug 13, 2024
12 tasks
@najlkin najlkin force-pushed the najlkin/fix-1D-mesh branch from e959d00 to 3938827 Compare August 14, 2024 16:22
@najlkin najlkin changed the title Fixed visualization of extruded 1D meshes [DO-NOT-MERGE] Fixed visualization of extruded 1D meshes Aug 14, 2024
@najlkin
Copy link
Copy Markdown
Contributor Author

najlkin commented Aug 14, 2024

@vladotomov , added a 1D test and waiting on approval of GLVis/data#6 . Update: approved by @tzanio

@najlkin najlkin changed the title [DO-NOT-MERGE] Fixed visualization of extruded 1D meshes Fixed visualization of extruded 1D meshes Aug 14, 2024
@najlkin najlkin requested a review from tzanio August 16, 2024 23:03
@tzanio tzanio merged commit 027cc9d into master Aug 17, 2024
@tzanio tzanio deleted the najlkin/fix-1D-mesh branch August 17, 2024 00:41
najlkin added a commit that referenced this pull request Sep 27, 2024
Updated for #307, #309  and #316 .
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants