Exclamation mark does not work with some keyboard layouts

[najlkin]

Exclamation mark for changing the texture type does not work with some keyboard layouts (like Czech).

Here is the output from tracking of key presses with Czech layout:

Event: SDL_KEYDOWN sym=1073742053 mod=4098
Event: SDL_KEYDOWN sym=167 mod=4098
Event: SDL_TEXTINPUT text[0..3]=33 0 0 0 (as codes 0-255)
Event: SDL_KEYUP sym=167 mod=4098
Event: SDL_KEYUP sym=1073742053 mod=4096

and for reference English layout (which works):

Event: SDL_KEYDOWN sym=1073742049 mod=4097
Event: SDL_KEYDOWN sym=49 mod=4097
Event: SDL_TEXTINPUT text[0..3]=33 0 0 0 (as codes 0-255)
Event: SDL_KEYUP sym=49 mod=4097
Event: SDL_KEYUP sym=1073742049 mod=4096

❓ This probably comes from #294

[najlkin]

This is wrong

glvis/lib/sdl.cpp

Line 276 in 2b8a8ec

if ((ks.sym >= 32 && ks.sym < 127) &&

but I do not know how to fix it. The thing is the key (167) is out of the range, but with Shift/Caps Lock it is translated to the range (33).

[najlkin]

Translation by SDL_GetScancodeName() would work for me, as it at least returns the key with English layout, which is apostrophe, but it is not universal 🤔

[najlkin]

Actually, it should be fine, because US keyboard matches ASCII table 😉

[najlkin]

This would be the fix working for me:

const char *scan_name = SDL_GetScancodeName(ks.scancode);
if ((scan_name[0] >= 32 && scan_name[0] < 127) && scan_name[1] == '\0'
    && (ks.mod & (KMOD_CTRL | KMOD_ALT | KMOD_GUI)) == 0)

Update: This possible fix is in #309 . Please test it!